Final-viewing-party C15 -Paper- Karla T. #69
Conversation
There was a problem hiding this comment.
Nice work Karla, you hit the learning goals here. For improvement I did notice 3 things to work on.
- Try using meaningful variable names (i.e. not x, y and z). It makes the code easier to read and debug.
- You don't need to loop through a dictionary if you already know the key you want. See my inline comments for an example.
- When you functions get really long (like in wave 5). You can break them up with helper functions. That makes things easier to debug, read and test.
Otherwise this was an outstanding 1st project, you should be proud!
| @@ -1,143 +0,0 @@ | |||
| .DS_Store | |||
There was a problem hiding this comment.
In the future don't delete the .gitignore file please.
| @@ -0,0 +1,251 @@ | |||
| #WAVE ONE | |||
|
|
|||
| def create_movie(title, genre, rating): | |||
| else: | ||
| return None | ||
|
|
||
| def add_to_watched(user_data, movie): |
| user_data["watched"].append(movie) | ||
| return user_data | ||
|
|
||
| def add_to_watchlist(user_data, movie): |
| user_data["watchlist"].append(movie) | ||
| return user_data | ||
|
|
||
| def watch_movie(user_data, title): |
| return final_list | ||
|
|
||
|
|
||
| def get_friends_unique_watched(user_data): |
There was a problem hiding this comment.
👍
With similar suggestions to the prior functions.
|
|
||
| #WAVE FOUR | ||
|
|
||
| def get_available_recs(user_data): |
There was a problem hiding this comment.
👍 With similar comments to the above, variable names and extra looping.
| for key,value in z.items(): | ||
| if z["genre"] in most_genre: | ||
| genre_rec.append(z) | ||
| #Removing duplicate genres |
There was a problem hiding this comment.
I think you mean duplicate movie recs
| return genre_rec_unq | ||
|
|
||
|
|
||
| def get_rec_from_favorites(user_data): |
There was a problem hiding this comment.
Question could you use a prior method to get the friends watched movies, or could you make a helper method to break that part up?
| for x in user_data["friends"]: | ||
| for y in x["watched"]: | ||
| for a,b in y.items(): | ||
| friend_watched.append(b) |
There was a problem hiding this comment.
This step would make an excellent helper method.
No description provided.