Al Leonard: Weather Report #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r display. The change immediately resets, why?
… Expand this feature to include each city option.
jbieniosek
reviewed
Jun 24, 2021
Comment on lines
+55
to
+56
| const submitButton = document.querySelector("#submitButton"); | ||
| submitButton.addEventListener("click", switchCity); |
There was a problem hiding this comment.
This isn't quite the behavior the requirements were asking for. For this section we were looking for two different pieces of functionality:
- An input listener on the text box that updates as the user enters text (https://www.w3schools.com/jsref/event_oninput.asp)
- a reset button that set the name back to a starting default
Comment on lines
+33
to
+44
| const addTemp = (event) => { // Add temp UP Behavior | ||
| state.givenTemp += 1; | ||
| const tempUp = document.querySelector("#givenTemp"); | ||
| tempUp.textContent = state.givenTemp; | ||
| numsChangeColor(); | ||
| } | ||
| const subTemp = (event) => { // Add temp DOWN Behavior | ||
| state.givenTemp -= 1; | ||
| const tempDown = document.querySelector("#givenTemp"); | ||
| tempDown.textContent = state.givenTemp; | ||
| numsChangeColor(); | ||
| }; |
| // document.getElementById('givenTemp') || document.querySelector("#givenTemp"); | ||
|
|
||
| ////////////////////////////// WAVE 2 ////////////////////////////////// | ||
| /////////////// METHODS (UP/DOWN TEMPERATURE) BEHAVIORS //////////////// |
There was a problem hiding this comment.
Wave 2 is missing the landscape change functionality.
| let cityTempText = ""; | ||
| let cityPicSrc = ""; | ||
|
|
||
| switch (city){ |
There was a problem hiding this comment.
Excellent use of a switch statement! (And nice extension!)
|
Great work on this project! There are a few pieces of functionality that are missing from Waves 2 & 5. Overall this project is green, it looks like you hit all of the learning goals, but I would recommend going over the missing pieces of functionality and at a minimum think through or pseudocode adding those in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a static Website that uses HTML, CSS, and JavaScript.