Alma-Pine #78
Open
Alma-Pine #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alope107
reviewed
Dec 21, 2021
Comment on lines
+31
to
+36
| <select id="skySelect"> | ||
| <option>Sunny</option> | ||
| <option>Cloudy</option> | ||
| <option>Rainy</option> | ||
| <option>Snowy</option> | ||
| </select> |
Comment on lines
+6
to
+8
| const skyOption = document.getElementById("skySelect"); | ||
| const getInput = skyOption.options[skyOption.selectedIndex].value; | ||
| const skyContainer = document.getElementById("sky"); |
There was a problem hiding this comment.
Nice use of consts here! Also good job getting elements by id.
Comment on lines
+29
to
+34
| const resetCity = () => { | ||
| const cityContainer = document.getElementById("cityNameInput"); | ||
| cityContainer.value = "Seattle 🌧"; | ||
| // reflect that reset on the header | ||
| updateCity(); | ||
| }; |
There was a problem hiding this comment.
I love how you re-use the updateCity function here!
Comment on lines
+63
to
+66
| incButton.addEventListener("click", function () { | ||
| tempValue += 1; | ||
| updateTemp(tempValue); | ||
| }); |
|
|
||
| // registerEventHandlers() | ||
|
|
||
| document.addEventListener("DOMContentLoaded", registerEventHandlers); |
There was a problem hiding this comment.
Good job on remembering to wait for the DOM to be loaded before registering the event handlers.
| justify-content: center; | ||
| } | ||
|
|
||
| .mainAarea { |
There was a problem hiding this comment.
I think a typo here prevents this style from being applied.
Comment on lines
+36
to
+41
| .temperatureText { | ||
| display:flex; | ||
| /* flex-direction: row-reverse; */ | ||
| align-items: center; | ||
| padding: 0px 10px 5px 10px; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.