&& Brittany Jones Ampers #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API MuncherWhat We're Looking For
|
CheezItMan
reviewed
May 14, 2018
| gem 'foundation-rails', '6.4.1.2' | ||
| group :development do | ||
| gem 'better_errors' | ||
| gem 'pry-rails' |
There was a problem hiding this comment.
This gem should also be under :test
|
|
||
| url = URL + "r=#{uri}&app_id=#{app_id}&app_key=#{app_key}" | ||
| result = HTTParty.get(url) | ||
| if result && result[0] |
There was a problem hiding this comment.
This should be something like:
if result && result[0] && result.code == 200
When the request fails, you're crashing
| <%= stylesheet_link_tag "application" %> | ||
| <%= csrf_meta_tags %> | ||
| </head> | ||
| <h1><%= link_to "Snack Time", root_path, alt: "link to home page" %></h1> |
There was a problem hiding this comment.
You've put this code outside the body element.
|
|
||
| describe RecipesController do | ||
| describe "index" do | ||
| it "can return list of matching recipes" do |
| end | ||
| end | ||
|
|
||
| describe "self.find_recipe" do |
There was a problem hiding this comment.
No attempt to find recipes with bad URIs
| end | ||
|
|
||
| it "will send bad_request if message sent to fake recipe page" do | ||
| VCR.use_cassette("create_action_bad") do |
There was a problem hiding this comment.
This test fails due to a bug in your wrapper, see my note there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions