Leticia - API Muncher - Ampers #27

LetiTran · 2018-05-07T07:02:13Z

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I took a while to read the Edamam API docs and then explore it with Postman to see the possible responses I would get and understand how to handle the information that I was given.
Describe your API Wrapper. How did you decide on the methods you created?	I wrote two methods, the first one (#find_recipes) for consuming the JSON given from the API and storing new Recipes objects created with it in an array. The second one (#find) uses the Recipe.id and formats it into the API id for each recipe and makes a new request to the API in order to get all the detailed information necessary of the specific recipe to display on #show by creating a new Recipe object again.
Describe an edge case or failure case test you wrote for your API Wrapper.	If given a bogus recipe id, it should return nil.
Explain how VCR aids in testing an API.	VCR records and then simulates a API response in order to reduce the dependency of the API (in case they are down or something like that) and also allows us to test as many times needed without actually making calls to API's and ending up using all of the requests available for our app (per times or cost).
What is the Heroku URL of your deployed application?	leti-muncher
Provide a link to the Trello board you used	https://trello.com/invite/b/nbwZacs9/1d7299a0ede77fbb5f47b27c6aa2e52c/api-muncher

… in root.

… generated from search

…api_wrapper (only happens if using #find method)

…box on the right using form_tag for the recipes controller

…et pipeline'

…et pipeline' 2

…et pipeline' 3

…et pipeline' 4

…essage for error

…page

CheezItMan · 2018-05-14T20:29:58Z

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits and good commit messages
Comprehension questions	Check
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Semantic HTML	Check, although some unnecessary html and `div` elements.
Errors are reported to the user	Error messages both for empty search results & erroneous URIs on the show action
API Wrapper to handle the API requests	Check
Controller testing	Check, see my notes on the search action. You're also missing a test for the homepage.
Lib testing	Check
Search Functionality	Check
List Functionality	Check
Show individual item functionality (link to original recipe opens in new tab)	Check
Styling
Responsive layout	Check, both on show and search results
List View shows 10 items at a time/pagination	Check
The app is styled to create an attractive user interface	Check
API Features
The App attributes Edaman	Check
The VCR cassettes do not contain the API key	ERROR See my notes in test_helper.rb
External Resources
Link to Trello Board	Check
Link to deployed app on Heroku	Check
Overall	You did well and hit all the learning goals. You do need to check my notes on your tests as you have some issues there. Overall however you did well. Nice work!

CheezItMan · 2018-05-14T20:20:41Z

app/views/layouts/application.html.erb

+  <header>
+    <!-- Menu for searching available in every page: -->
+
+    <div class="title-bar" data-responsive-toggle="responsive-menu" data-hide-for="medium">


This doesn't seem to do anything.

CheezItMan · 2018-05-14T20:24:29Z

test/controllers/recipes_controller_test.rb

+describe RecipesController do
+
+  describe 'index' do
+    it "Should get a list of Recipes when give a term" do


What about when Query is empty or missing, or not a valid search term?

CheezItMan · 2018-05-14T20:26:38Z

test/lib/edamam_api_wrapper_test.rb

+      VCR.use_cassette("recipes") do
+        response = EdamamApiWrapper.find_recipes("chicken")
+
+        response[0].must_be_kind_of Recipe


You should loop through the array and verify that all elements are instances of Recipe.

CheezItMan · 2018-05-14T20:29:06Z

test/test_helper.rb

+    :match_requests_on => [:method, :uri, :body] # The http method, URI and body of a request all need to match
+  }
+  # Don't leave our Slack token lying around in a cassette file.
+  config.filter_sensitive_data("<SLACK_TOKEN>") do


Gah you're filtering the Slack token and not the Edaman token!

doh!

LetiTran added 30 commits May 2, 2018 13:57

Initialized rails files and defined routes and recipes controller

a1d69fa

Added gems and api_wrapper and class for it

ec65084

Created api_wrapper and initial methods

038d45f

Added more attributes to recipe and defined id using regex

540e7e6

Added functionality of searching for a recipe with a term from a form…

e7a93e1

… in root.

Added a searching form as a header.

2a6152a

Added the right title and text

b0f71d1

Added EdamamApiWrapper#find to search a recipe with an id on the list…

d30df2c

… generated from search

Basic view of a recipe implemented.

c517145

added portion yield to recipe

1809054

Added basic pagination. needs to fix style.

0e5afbb

Fixed that problem with only 10 hits oer request. Now set it to 50

38c9453

Fixed that uninitialized constant TestUnit problem

de8dff4

Changed Recipe to receive a hash as an argument

b6e419a

Changed argument passed to Recipe a hash as an argument

21d5fad

Completed tests on Recipe class for now.

d01ffac

Added gem for VCR

8015743

Added VCR config in test_helper file

8e0df1f

Started tests for api

c6fbb65

Added code for openning a link in a new tab.

83001cd

Changed #find to make its own API call

e9af3f8

Changed #find to make its own API call

f40d4ae

Addapted to only initialize details of a recipe if they are given by …

d1e0966

…api_wrapper (only happens if using #find method)

Added method for 'Not Found'

82c58e8

Added call to not_found method if no recipe is returned in #show

ab976f2

Basic tests for api_wrapper

e366b2e

Deleting unecessary stuff

bac075b

Changed application view to show a resposinve menu and have a search …

f118738

…box on the right using form_tag for the recipes controller

Added new icon

84547f7

Implemented first steps for basic overall design.

42b7b39

LetiTran added 24 commits May 6, 2018 15:08

Change button style

25c9469

Fixed button bug

f997653

Trying to fix heroku 'The asset recipe-icon is not present in the ass…

c77ec50

…et pipeline'

Trying to fix heroku 'The asset recipe-icon is not present in the ass…

269ea77

…et pipeline' 2

Trying to fix heroku 'The asset recipe-icon is not present in the ass…

8865f5e

…et pipeline' 3

Trying to fix heroku 'The asset recipe-icon is not present in the ass…

d7ab75c

…et pipeline' 4

Fixed pagination style

f91685a

Added more style and fixed display of index

8385695

Fixed changes that needed to be done after adding some style to 'card'

75f91e5

Trying to fix why the search form wont work on heroku

d8a5534

Trying image icon for heroku again

ce70846

Still testing image

a98a183

Image in home-page working

8d7cc87

Fixed empty grey box that was apeering when on mobile

3f06f0f

Fixed bottom of index display

ae47ed0

Added one more api test and deleted unecessary lines

87e4f81

Added flash messages on body

957b18a

Changed how #show was dealing with wrong recipe ids and added flash m…

1b7c911

…essage for error

Deledt not_found method, not needed here

46d1ee4

Tests for recipes_controller

9908c3b

Trying to make display of index better

2e5797b

Finished testing controller

a4fa400

Fixed uncentralized root-page card because of changes made for index …

3364287

…page

Centralized h4

eb70c5d

CheezItMan reviewed May 14, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Leticia - API Muncher - Ampers #27

Leticia - API Muncher - Ampers #27

LetiTran commented May 7, 2018

CheezItMan commented May 14, 2018

CheezItMan May 14, 2018

CheezItMan May 14, 2018

CheezItMan May 14, 2018

CheezItMan May 14, 2018

Leticia - API Muncher - Ampers #27

Are you sure you want to change the base?

Leticia - API Muncher - Ampers #27

Conversation

LetiTran commented May 7, 2018

API Muncher

Comprehension Questions

CheezItMan commented May 14, 2018

API Muncher

What We're Looking For

CheezItMan May 14, 2018

Choose a reason for hiding this comment

CheezItMan May 14, 2018

Choose a reason for hiding this comment

CheezItMan May 14, 2018

Choose a reason for hiding this comment

CheezItMan May 14, 2018

Choose a reason for hiding this comment