Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Kaitlin #43

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Ampers: Kaitlin #43

wants to merge 25 commits into from

Conversation

kcforsman
Copy link

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? I used postman a lot and intentionally hit the 5 within a minute to see the differences in the responses. I did lot of testing the different ranges for the search and tested for responses with no hits or less than 100 responses to adjust the pagination to consider the limited responses.
Describe your API Wrapper. How did you decide on the methods you created? I have two methods, one for requesting a list of recipes and one for requesting a specific recipe. I pretty much chose this approach to practice the calls, because my initial response involved a class variable that only required the one call to get the list and for some reason seemed to cache the recipe class variable even though it shouldn't have. I also was worried that storing the data that might appear across browsers rather than be limited to a specific session.
Describe an edge case or failure case test you wrote for your API Wrapper. I found the free version of Edamam only give you the first 100 responses for a single group of search terms. So I wrote a test for if the user tried to enter an index greater than or equal to 100 and how to handle that request.
Explain how VCR aids in testing an API. It creates a copy of a response so that when writing test and then running them you don't actually make endless calls to the API
What is the Heroku URL of your deployed application? https://kf-muncher.herokuapp.com/
Provide a link to the Trello board you used https://trello.com/b/OUlConpK/muncher

kcforsman added 25 commits May 2, 2018 15:13
… created recipe controller with root, index, and show, created EdamamApiWrapper and Recipe files in lib
…n instance can be initialized and has appropriate attr_reader methods
…t of Recipe instances rather than a hash of data, and changed wrapper class method to create instances
…rm to the root view that allows user to submit a search, and content to the index that shows the first 10 results
…cipe show pages in index.html.erb, and information calls in show views for a recipe -- found recipe object is not sending through params
…to characters after the underscore, and adjusted index link in index view to take only the recipes snippet of the uri from recipe id
…one specif recipe and create an instance of the Recipe from the data
…f recipe, and adjusted show view to display all recipe details
…roller to take in params for search ranges, and updated wrapper list_recipes to handle a range input
… for edamam only give 100 returns for a search term, created a partial view for the pagination to dry up the code in the index view, and adjusted list_recipe and controller method etc to only take the first index for from instead of the first and last
…ot view and top of index view instead, deleted header navigation for application.html.erb and added application name to head and header h1, and adjusted show link to original url to open into a new tab
…ts for self.list_recipes, tests generated cassette and added to existing cassette, and edited wrapper methods to consider edge cases
@CheezItMan
Copy link

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check
General
Rails fundamentals (RESTful routing, use of named paths) Check
Semantic HTML Check
Errors are reported to the user Error reported shown with invalid URIs for show actions and when there are no search results
API Wrapper to handle the API requests Check
Controller testing Check
Lib testing Some of your tests here are repetitive and don't add very much, otherwise quite good
Search Functionality Check
List Functionality Check
Show individual item functionality (link to original recipe opens in new tab) Check
Styling
Responsive layout Not really responsive
List View shows 10 items at a time/pagination Check
The app is styled to create an attractive user interface Well done
API Features
The App attributes Edaman Check
The VCR cassettes do not contain the API key Check
External Resources
Link to Trello Board Link provided, I don't have access
Link to deployed app on Heroku Check
Overall Well done, you hit all the major learning goals. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants