forked from AdaGold/api-muncher
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ampers: Kaitlin #43
Open
kcforsman
wants to merge
25
commits into
Ada-C9:master
Choose a base branch
from
kcforsman:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ampers: Kaitlin #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… created recipe controller with root, index, and show, created EdamamApiWrapper and Recipe files in lib
… for minitest mentioned in class
…generated a cassette
…n instance can be initialized and has appropriate attr_reader methods
…t of Recipe instances rather than a hash of data, and changed wrapper class method to create instances
…rm to the root view that allows user to submit a search, and content to the index that shows the first 10 results
…cipe show pages in index.html.erb, and information calls in show views for a recipe -- found recipe object is not sending through params
…to characters after the underscore, and adjusted index link in index view to take only the recipes snippet of the uri from recipe id
…one specif recipe and create an instance of the Recipe from the data
…f recipe, and adjusted show view to display all recipe details
…roller to take in params for search ranges, and updated wrapper list_recipes to handle a range input
… for edamam only give 100 returns for a search term, created a partial view for the pagination to dry up the code in the index view, and adjusted list_recipe and controller method etc to only take the first index for from instead of the first and last
…eroku deploying error
…ot view and top of index view instead, deleted header navigation for application.html.erb and added application name to head and header h1, and adjusted show link to original url to open into a new tab
…ts for self.list_recipes, tests generated cassette and added to existing cassette, and edited wrapper methods to consider edge cases
…o the edamam api wrapper tests
…i wrapper to pass tests as they failed
API MuncherWhat We're Looking For
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions