Ampers: Maddie, Angela, Katie, Nora

[kcforsman]

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question	Answer
How did your team break up the work to be done?	Spent 2 days outline and planning and deciding what we wanted to do as a group (based on difficulty and desire for symmetry). Then we would meet up at the beginning and end of the day to split tasks or work on blocker as a group.
How did your team utilize git to collaborate?	We worked on branches on our local computers, would merge the master onto branch and then merge branch back to master before pushing. We didn't use pull requests on Github. Due to the planning behind the project, we found this worked around creating a lot of merge conflicts.
What did your group do to try to keep your code DRY while many people collaborated on it?	We would go through the code to refactor and pull out common logic. One way we did this was by setting the permissions for require login and confirm current merchant.
What was a technical challenge that you faced as a group?	Controller Tests. Nora dealt with the figuring out joint table issues. Cart's presence in everything was also a problem. Difficulties with separating out user stories into what they meant technically.
What was a team/personal challenge that you faced as a group?	Differences in working approach caused some frustration. Difficulties with overcoming how to handle problem and fairly convey why one approach would be preferred. Dealing with personal frustrations and miscommunications in an effective and appropriate way. Also, learning to handle the difference between a friendship and a business relationship and not take things personally
What could your team have done better?	For where we are in the learning process, it honestly feels like we did the best we could. What can we say, we're hipsters
What was your application's ERD? (include a link)	https://www.lucidchart.com/documents/edit/2df64d3e-dd65-46cc-9222-fd98be91b243/0?shared=true&
What is your Trello URL?	https://trello.com/b/5E7gdTbT/betsy
What is the Heroku URL of your deployed application?	https://hipsty.herokuapp.com/

[tildeee]

bEtsy

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with all members contributing	x
Answered comprehension questions	x
Trello board is created and utilized in project management	x
Heroku instance is online	x
General
Nested routes follow RESTful conventions	x
oAuth used for User authentication	x
Functionality restricted based on user roles	I can edit other merchant's products (for example: I am merchant id 8, and I can go to https://hipsty.herokuapp.com/merchants/8/products/1/edit )
Products can be added and removed from cart	x
Users can view past orders	x
Merchants can add, edit and view their products	x
Errors are reported to the user	x
Order Functionality
Reduces products' inventory	x
Cannot order products that are out of stock	x
Changes order state	x
Clears current cart	x
Database
ERD includes all necessary tables and relationships	I don't have access to your ERD :(
Table relationships	x
Models
Validation rules for Models	x
Business logic is in the models	x
Controllers
Controller Filters used to DRY up controller code	x
Testing
Model Testing	x
Controller Testing	VERY thorough :) besides the few tests that weren't implemented/were commented out
Session Testing	x
SimpleCov at 90% for controller and model tests	92.12%
Front-end
The app is styled to create an attractive user interface	x
Content is organized with HTML5 semantic tags	x
CSS is DRY	x
Overall

Only the person who submitted the PR will get an email about this feedback. Please let the rest of your team know about it.

Really wonderful job overall with this project! The site looks great and functions great, it's very complete. I didn't run into any major snags and it hits all of the objectives.

Above all, the code looks pretty good; it's on average short and concise and dense. The tests look pretty good too. I've tried making small comments throughout the code when I can, but overall it's good.

Just a weird small note: If I don't put a valid Photo URL value for a product I'm creating or editing as a merchant, it will break the views that try to render that product and its thumbnail.

Oooh, NICE ABOUT PAGE Y'ALL!
Also I felt really burned by a lot of these messages... my trust fund hipsterdom... all the shrug emoji... "You're doing something wrong" ... Hehehee. :)

Again: good work; this project was a lot and you all coded, styled, coordinated, designed a lot.

[tildeee]

These each loops that really just populate the @order_products array could really be improved with an enumerable method that filters based on a boolean, like select or find_all

[tildeee]

Good use of view helpers!

[tildeee]

I think ul_table is an interesting name for an ID: it doesn't really describe what's going on, besides that it's a table inside of a UL (then why wouldn't you use ul table?), so it doesn't really help other developers who are looking at this.

Also in general, CSS ids/classes are hyphenated

[tildeee]