Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers : Abinnet #24

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Ampers : Abinnet #24

wants to merge 20 commits into from

Conversation

Abiaina
Copy link

@Abiaina Abiaina commented Jun 16, 2018

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. I take user input in a form that has specific input fields labeled in the return of the NewCardForm component. When the event change happens (user clicks the 'inspire' button) it calls the addCard function from Board component. To ensure that the call is not done immediately the addCard is passed in from props via an anonymous function in NewCardForm component.
How did you learn how to use the API? Through postman, console.log the api responses, and going to the get request site itself to see all the cards/any changes to the api I made in postman or my app.
What function did you use to place the GET request from the API to get the list of cards? Why use that function? I used a componentDidMount function. This makes sure that each card component loads (and other child components of board) and a DOM outline (sort of outline) forms and the axios get request can fill in the components with its data. Basically, there has to be a place for the data to go before the data is collected from the API.
Explain the purpose of a Snapshot test. It allows us to test the different components and their child components tags to with the expected and actual values using mocked up data and simulated user activity to make sure the code works. I did shallow test so it didn't extend to the child components
What purpose does Enzyme serve in testing a React app? It is a testing library with cool functions that help set up mock environments for testing the app like simulate, shallow, and mount.
Summary

@CheezItMan
Copy link

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check
General
Card Component renders the data provided as props Check
Board Component takes a URL and renders the list of Cards and passes in callback functions Check
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component Check
API
GET request made in componentDidMount Check
DELETE request made in callback function Check
POST request made in callback function passed to NewCardForm component. Check
Snapshot testing Check, nice work with the testing of the form.
Styling Good use of Dee's styling, and nice work on the delete button.
Overall Nicely done, you hit all the learning goals of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants