Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maja Octos #28

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Maja Octos #28

wants to merge 6 commits into from

Conversation

mgraonic
Copy link

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. Information gets saved to the state (via the onChange function) as the user types information. Once the form gets submitted, the onSubmit function invokes the addCardcallback function and passes in the form's state. The form's state gets promoted to a function in the Board which makes a POST request and updates the boards state accordingly.
How did you learn how to use the API? Pasted the urls into Chrome and used a JSON rendering extension to just look at what came back.
What function did you use to place the GET request from the API to get the list of cards? Why use that function? componentDidMount. Had to make sure the component was mounted, otherwise making the API call may delay page loading/mounting.
Explain the purpose of a Snapshot test. To ensure that the changes you are making are intentional by showing you a diff between your initial desired look and current.
What purpose does Enzyme serve in testing a React app? Enzyme is a testing library which makes it easier to manipulate, traverse and make assertions on our React components
Summary I really enjoyed the series of short fill-in-the-blanks-type exercises that we got with React. It's great practice at reading code and gleaning new ways to organize your js. I especially appreciate that styling was provided to isolate React/testing as the focal point of the assignment. This approach to learning helped solidify the concepts much more than just a series of lectures with one big project finale! Future cohorts would benefit if we approached learning Ruby in the same way as we did React.

@CheezItMan
Copy link

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Enough commits, good commit messages
Comprehension questions Check, glad you enjoyed the approach
General
Card Component renders the data provided as props Check
Board Component takes a URL and renders the list of Cards and passes in callback functions Check
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component Check
API
GET request made in componentDidMount Check
DELETE request made in callback function Check, good use of splice
POST request made in callback function passed to NewCardForm component. Check
Snapshot testing Check, nice work with testing form actions as well.
Styling Looks good
Overall Nice work, you hit all the learning goals!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants