-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ana Lisa Sutherland -- Octos C9 #29
base: master
Are you sure you want to change the base?
Conversation
…ng card data nor the array. But beginning of app built
…ds added are currently deleted after refreshing. Wave 1 complete. Will move on to Wave 2
…ser with more descriptions. Still needs tests for it
…n submit to reflect what was being returned in the API
…us updates, and now have updated status displays
… build out emoji portion for it to work
…on error is failing. Need to fix later
…e have 404 found, need to fix. Think it might be the same issue linked to the emoji and validation error. Will attempt to fix and reassess
… But now I have emojis at least. Sigh.
…ot reset after refreshing. HUZZAH.
…r that is returning a 404, do not know why and troubleshooting has yielded nothing. Ran out of time, will ask instructors in the AM
Inspiration BoardWhat We're Looking For
Good work overall. It looks like you were very close on deleting a card, and everything else works beautifully. My one piece of advice after this submission is for you to keep practicing your debugging skills! Here is the general pattern I follow:
I am quite happy with this submission, so keep up the hard work! |
// Call back function for deleting card | ||
deleteCard = ( index, id) => { | ||
axios.delete(CARDS_URL + `${id}`) | ||
.then((response) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you're missing a /
in your URL before the ID. When I added that, this code worked fine.
The way I found this was by noticing the error code - 404 indicates not found, which means either you have a bad card ID, or a bad URL format. I then looked in Chrome's network tab to see what you were actually sending, and noticed the missing /
.
const header = wrapper.find('h3'); | ||
// Assert: check that the h3 inner text is 'Something' | ||
|
||
expect(header.text()).toEqual('Something'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be wise to put the string something
in a variable here.
return ( | ||
<section className={`status ${this.props.type}`}> | ||
{this.props.message} | ||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got classes defined for this Status
component, but no CSS that uses them!
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions