Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers - Sara S - Add personal portfolio files #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CheerOnMars
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?
Why is it important to consider and use semantic HTML?
How did you decide to structure your CSS?
What was the most challenging piece of this assignment?
Describe one area that you gained more clarity on when completing this assignment
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@tildeee
Copy link

tildeee commented Apr 2, 2018

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage one commit
Answered comprehension questions nope
Page fully loads x
No broken links (regular or images) x
Includes at least 4 pages and styling minimal content and original styling
HTML
Uses the high-level tags for organization: header, footer, main didn't use these, used div instead and just put classes to label them
Appropriately using semantic tags: section, article, etc. x
All images include alternate text main page has an image with an alt text of just ""
CSS
Using class and ID names in style declarations x
Style declarations are DRY x
Overall

The project/code definitely gets the job done, but it doesn't fulfill the project prompt that well-- I was hoping to learn a little bit more about you :p

We're not grading these projects on originality but a lot of these styles are borrowed from some in-class live codes

Also, the indentation in every file is pretty wild throughout? I think there are indentation and spacing issues in every file!

Anyway, the project meets the requirements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants