Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octos -Ari -Personal Portfolio Site #32

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

arrriiii
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? yes, forgot to add titles to each html page.
Why is it important to consider and use semantic HTML?
How did you decide to structure your CSS? I wanted to keep special effects (animations) on the landing page and keep the other pages more structured and simple.
What was the most challenging piece of this assignment? I found using grid to be challenging. The grid layout doesn't offer a lot of flexibility for future changes.
Describe one area that you gained more clarity on when completing this assignment When to use grid and *mostly when to use flex or block.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? No. There are github links to each project on the portfolio page.
Overall

@tildeee
Copy link

tildeee commented Apr 5, 2018

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage x
Answered comprehension questions x, missing answers
Page fully loads x
No broken links (regular or images) x
Includes at least 4 pages and styling x
HTML
Uses the high-level tags for organization: header, footer, main didn't use main
Appropriately using semantic tags: section, article, etc. x
All images include alternate text x
CSS
Using class and ID names in style declarations x
Style declarations are DRY x
Overall

The site looks great and the code looks great! Great work on this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants