Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website - Cara - Octos #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MississippiBrenn
Copy link

@MississippiBrenn MississippiBrenn commented Mar 19, 2018

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, I had to change the format of my UL's and also take out some of the section tags I had that were orphaned. Also I removed some comments and html that I wasn't using and was empty.
Why is it important to consider and use semantic HTML? So that when we look at the page, we are not confused by how things are structured, and other people and machines can easily access what is going on.
How did you decide to structure your CSS? I went through and built separate CSS for each page, and then went back through and refactored what was common across pages. I utilized flex boxes for smallerpieces, and grid for overall.
What was the most challenging piece of this assignment? I got confused around github, and ended up pushing to the wrong place, and then re creating a branch from the same origin and not trying later to conform them together, but I ended up losing all my original commits and in the end had to force push to bring my website back to the copy I had saved locally. Lesson learned (hopefully).
Describe one area that you gained more clarity on when completing this assignment I got better about using flex boxes, and pictures in the background. I figrued out the format I wanted.
Did you deploy to GitHub Pages? If so, what is the URL to your website? Yes, www.caraencoded.com
Overall

@MississippiBrenn MississippiBrenn changed the title Website Website - Cara - Octos Mar 19, 2018
@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage no, but it looks like you're already aware of this
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main you make good use of <header> and <footer>. Everything in between should be in a <main>.
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes - good work using multiple files to keep things organized
Overall Great work overall! Site is attractive and easy to navigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants