Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamila Octos C9 #38

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Jamila Octos C9 #38

wants to merge 5 commits into from

Conversation

Jcornick21
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Didnt run the validator before submitting. I will before i put anything live.
Why is it important to consider and use semantic HTML? Because it makes it easier to know what is where in the html. It also makes the site overall more accessible to folks using screen readers
How did you decide to structure your CSS? I put the most general rules at the top and more specific rules toward the bottom and commented. If I had time to add the individual css pages i would have done the same and tried to comment and group rules together by the sections they most impact
What was the most challenging piece of this assignment? Time. there is so much you can do and such finite time with all the other assignments.
Describe one area that you gained more clarity on when completing this assignment I gained a lot of clarity around grid especially how to get content where i want it on a grid as well as how to you flex within grid.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? No i didnt
Overall

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) some image links don't have a src attribute
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall I like the layout and visual feel, but I feel the learning here would be more interesting if you had more varied content to style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants