Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers C9 Mariko A. #42

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Ampers C9 Mariko A. #42

wants to merge 6 commits into from

Conversation

marikoja
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? the html validator pointed out the need for header texts for each section.
Why is it important to consider and use semantic HTML? Using semantic HTML is important to keep the code clear and concise without frivolous lines of code.
How did you decide to structure your CSS? I really struggled with the flex box so the majority of my css is structured using css grid.
What was the most challenging piece of this assignment? Design, it feels like every choice I made felt like an assault on my eyes.
Describe one area that you gained more clarity on when completing this assignment I feel like I became more comfortable with css grid.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@tildeee
Copy link

tildeee commented Apr 2, 2018

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage x
Answered comprehension questions "assault on my eyes" lol oh no!
Page fully loads x
No broken links (regular or images) x
Includes at least 4 pages and styling x
HTML
Uses the high-level tags for organization: header, footer, main didn't use a main, but that's okay!
Appropriately using semantic tags: section, article, etc. x
All images include alternate text x
CSS
Using class and ID names in style declarations x
Style declarations are DRY x
Overall

You have your index.html in the pages folder-- it'd be better if index.html were in the root directory

Otherwise, the code looks good and the site looks good! Good work overall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants