Ampers - Maddie Shields / personal site

[madaleines]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	Not that I recall
Why is it important to consider and use semantic HTML?	With respect to readablity I can see how it is "divided" or "sectioned" up
How did you decide to structure your CSS?	I really tried to do grid and flex but as I was working on my header and making it fixed I had to scratch grid for the whole container to make it work. Need to re-visit this
What was the most challenging piece of this assignment?	Grid and flex being used together
Describe one area that you gained more clarity on when completing this assignment	Researching showed html tags could have a class and ID which I haven't applied yet but I can see being very useful with CSS to apply to specific id's or general classes.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

[tildeee]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	one commit
Answered comprehension questions	x
Page fully loads	x
No broken links (regular or images)	x
Includes at least 4 pages and styling	x
HTML
Uses the high-level tags for organization: header, footer, main	some, but mostly relied on divs
Appropriately using semantic tags: section, article, etc.	some, but mostly relied on divs
All images include alternate text	nope
CSS
Using class and ID names in style declarations	x
Style declarations are DRY	x
Overall

in some of your images, you do inline styles to declare width-- i don't think you have a situation where you should be using inline styles!

Your taste in visual design is apparent-- you picked a great font and layout. Your transitions are great too!

For some reason I'm running into a scrolling issue where it makes it impossible to scroll through the content on the about and play pages. Luckily I can just read the code :p

You have a section with the class nav-padding in which its only purpose is to help with layout. Usually for problems like that, we try to do that completely in CSS without touching the HTML

Otherwise, looks good! good work overall