Merge branch 'unparsing_config_fixes' into 'master'

Fix multiple unparsing config issues

Closes eng/ide/gnatformat#62, eng/ide/gnatformat#63, eng/ide/gnatformat#64, eng/ide/gnatformat#65, eng/ide/gnatformat#66, eng/ide/gnatformat#67, eng/ide/gnatformat#68, eng/ide/gnatformat#69, and eng/ide/gnatformat#70

See merge request eng/libadalang/libadalang!1730

testsuite/tests/unparsing/decl_expr/input.ada

@@ -0,0 +1,8 @@
+function Is_Subp_Decl_An_Import_With_Expression
+  (Subp : Basic_Decl'Class) return Boolean
+is (declare
+      Import_Aspect : constant Aspect :=
+        Subp.P_Get_Aspect (Langkit_Support.Text.To_Unbounded_Text ("Import"));
+    begin
+      Exists (Import_Aspect)
+      and then (To_Lower (+Value (Import_Aspect).Text) /= "false"));

testsuite/tests/unparsing/decl_expr/test.out

@@ -0,0 +1,8 @@
+function Is_Subp_Decl_An_Import_With_Expression
+  (Subp : Basic_Decl'Class) return Boolean
+is (declare
+      Import_Aspect : constant Aspect :=
+        Subp.P_Get_Aspect (Langkit_Support.Text.To_Unbounded_Text ("Import"));
+    begin
+      Exists (Import_Aspect)
+      and then (To_Lower (+Value (Import_Aspect).Text) /= "false"));

testsuite/tests/unparsing/decl_expr/test.yaml

@@ -0,0 +1,4 @@
+driver: unparser
+rule: subp_decl
+description: |
+  Test indentation of `f_decls` and `f_expr` on a `DeclExpr`.

testsuite/tests/unparsing/if_stmt/long_last_elsif_cond_expr/input.ada

@@ -0,0 +1,49 @@
+if Subp.P_Is_Ghost_Code or else Is_Function_With_Ghost_Return (Subp) then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image & "Can't fuzz ghost code subprograms.");
+elsif Subp.Kind in Ada_Abstract_Subp_Decl then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image & "Can't fuzz abstract subprograms.");
+elsif Get_Subp_Params (Subp).Is_Null then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image
+          & "Can't subprograms with no parameters.");
+elsif not Has_Input_Parameters (Subp) then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image
+          & "Can't fuzz subprograms with no 'in' or "
+          & "'in out' parameters");
+elsif Is_Subp_Decl_An_Import_With_Expression (Subp) and not Is_Intrinsic_Subprogram (Subp) then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image
+          & "Can't fuzz subprograms where Imports aspect "
+          & "values are derived from expressions.");
+elsif Is_Subp_Decl_Null (Subp)
+  and not Is_Expr_Function (Subp)
+  and not Is_Subp_Decl_An_Import (Subp)
+then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image
+          & "Can't fuzz subprograms with null "
+          & "specifications.");
+else
+  null;
+end if;

testsuite/tests/unparsing/if_stmt/long_last_elsif_cond_expr/test.out

@@ -0,0 +1,50 @@
+if Subp.P_Is_Ghost_Code or else Is_Function_With_Ghost_Return (Subp) then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image & "Can't fuzz ghost code subprograms.");
+elsif Subp.Kind in Ada_Abstract_Subp_Decl then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image & "Can't fuzz abstract subprograms.");
+elsif Get_Subp_Params (Subp).Is_Null then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image & "Can't subprograms with no parameters.");
+elsif not Has_Input_Parameters (Subp) then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image
+          & "Can't fuzz subprograms with no 'in' or "
+          & "'in out' parameters");
+elsif Is_Subp_Decl_An_Import_With_Expression (Subp)
+  and not Is_Intrinsic_Subprogram (Subp)
+then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image
+          & "Can't fuzz subprograms where Imports aspect "
+          & "values are derived from expressions.");
+elsif Is_Subp_Decl_Null (Subp)
+  and not Is_Expr_Function (Subp)
+  and not Is_Subp_Decl_An_Import (Subp)
+then
+   return
+     Non_Fuzzable_Subprogram'
+       (Declaration => Subp.As_Basic_Decl,
+        Reason      =>
+          +Subp.Full_Sloc_Image
+          & "Can't fuzz subprograms with null "
+          & "specifications.");
+else
+   null;
+end if;

testsuite/tests/unparsing/if_stmt/long_last_elsif_cond_expr/test.yaml

@@ -0,0 +1,5 @@
+driver: unparser
+rule: stmt
+description: |
+  Test that if the last `ElsifStmtPart` is long, it first breaks before the
+  `then` keyword and then the underlying `f_cond_expr` field.

testsuite/tests/unparsing/named_stmt/test.out

@@ -1,4 +1,4 @@
-Foo:
+Foo :
 loop
    null;
    null;

testsuite/tests/unparsing/paren_expr/inside_if/input.ada

@@ -0,0 +1,10 @@
+if (Key = Last_Hang
+    or Key = Last_Crash
+    or Key = Last_Find
+    or Key = Slowest_Execution_MS
+    or Key = Execs_Done)
+  and Val = "0"
+then
+   Data_Valid := False;
+   return Val;
+end if;

testsuite/tests/unparsing/paren_expr/inside_if/test.out

@@ -0,0 +1,10 @@
+if (Key = Last_Hang
+    or Key = Last_Crash
+    or Key = Last_Find
+    or Key = Slowest_Execution_MS
+    or Key = Execs_Done)
+  and Val = "0"
+then
+   Data_Valid := False;
+   return Val;
+end if;

testsuite/tests/unparsing/paren_expr/inside_if/test.yaml

@@ -0,0 +1,5 @@
+driver: unparser
+rule: if_stmt
+descrition: |
+  Test that the expression inside a `ParenExpr` has a continuation line
+  indentation of 1.

testsuite/tests/unparsing/raise_stmt/long_error_message_concatenation/input.ada

@@ -0,0 +1 @@
+raise Some_Exception with "AAAAAAAAAAAAAAAAAAAAAAAA" & "AAAAAAAAAAAAAAAAAAAAAAAA" & "AAAAAAAAAAAAAAAAAAAAAAAA" & "AAAAAAAAAAAAAAAAAAAAAAAA";

testsuite/tests/unparsing/raise_stmt/long_error_message_concatenation/test.out

@@ -0,0 +1,6 @@
+raise Some_Exception
+  with
+    "AAAAAAAAAAAAAAAAAAAAAAAA"
+    & "AAAAAAAAAAAAAAAAAAAAAAAA"
+    & "AAAAAAAAAAAAAAAAAAAAAAAA"
+    & "AAAAAAAAAAAAAAAAAAAAAAAA";

testsuite/tests/unparsing/raise_stmt/long_error_message_concatenation/test.yaml

@@ -0,0 +1,7 @@
+driver: unparser
+rule: raise_stmt
+description: |
+  This test checks the formatting of a `RaiseExpr` that has a long
+  `f_error_message` which consists of concatenations.
+  It is expected `f_error_message` to be continuation line indented relative to
+  `with`.

testsuite/tests/unparsing/reduce_attribute_ref/break_after_reduce/input.ada

@@ -0,0 +1,3 @@
+[for Value of Foo_Bar => Value]'
+  Reduce
+    (Foo_Bar_Bar_Bar_Bar_Bar_Bar_Bar, Bar_Foo_Foo_Foo_Foo_Foo_Foo_Foo_Foo_Foo)

testsuite/tests/unparsing/reduce_attribute_ref/break_after_reduce/test.out

@@ -0,0 +1,3 @@
+[for Value of Foo_Bar => Value]'
+  Reduce
+    (Foo_Bar_Bar_Bar_Bar_Bar_Bar_Bar, Bar_Foo_Foo_Foo_Foo_Foo_Foo_Foo_Foo_Foo)

testsuite/tests/unparsing/reduce_attribute_ref/break_after_reduce/test.yaml

@@ -0,0 +1,5 @@
+driver: unparser
+rule: expr
+description: |
+  This tests checks that a `ReduceAttributeRef` first tries to break after the
+  `Reduce` attribute and not the `f_args` field.

testsuite/tests/unparsing/reduce_attribute_ref/break_before_reduce/input.ada

@@ -0,0 +1,2 @@
+[for Value of Foo_Bar => Value]'
+  Reduce (Foo_Bar_Bar_Bar_Bar, Bar_Foo_Foo_Foo_Foo)

testsuite/tests/unparsing/reduce_attribute_ref/break_before_reduce/test.out

@@ -0,0 +1,2 @@
+[for Value of Foo_Bar => Value]'
+  Reduce (Foo_Bar_Bar_Bar_Bar, Bar_Foo_Foo_Foo_Foo)

testsuite/tests/unparsing/reduce_attribute_ref/break_before_reduce/test.yaml

@@ -0,0 +1,5 @@
+driver: unparser
+rule: expr
+description: |
+  This tests checks that a `ReduceAttributeRef` is first broken before the
+  `Reduce` attribute.

testsuite/tests/unparsing/reduce_attribute_ref/long/input.ada

@@ -0,0 +1,5 @@
+[for Value_AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA of AAAAAAAAAAAAAAAAAAAAAA
+ => Value]'
+  Reduce
+    (Fooooooooooooooooooooooooooooooooo,
+     Baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaar)

testsuite/tests/unparsing/reduce_attribute_ref/long/test.out

@@ -0,0 +1,5 @@
+[for Value_AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA of AAAAAAAAAAAAAAAAAAAAAA
+ => Value]'
+  Reduce
+    (Fooooooooooooooooooooooooooooooooo,
+     Baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaar)

testsuite/tests/unparsing/reduce_attribute_ref/long/test.yaml

@@ -0,0 +1,5 @@
+driver: unparser
+rule: expr
+description: |
+  This tests checks the indentation when all possible line breaks of a
+  `ReduceAttributeRef` are active.

testsuite/tests/unparsing/reduce_attribute_ref/short/input.ada

@@ -0,0 +1 @@
+[for Value of A => Value]'Reduce ("+", 0)

testsuite/tests/unparsing/reduce_attribute_ref/short/test.out

@@ -0,0 +1 @@
+[for Value of A => Value]'Reduce ("+", 0)

testsuite/tests/unparsing/reduce_attribute_ref/short/test.yaml

@@ -0,0 +1,5 @@
+driver: unparser
+rule: expr
+description: |
+  Test that when a `ReduceAttributeRef` fits in a single line, it does not
+  break.

testsuite/tests/unparsing/return_stmt/long_breaking_return_expr/input.ada

@@ -0,0 +1 @@
+return Fooooooooooooooooooooo / Baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaar;

testsuite/tests/unparsing/return_stmt/long_breaking_return_expr/test.out

@@ -0,0 +1,2 @@
+return
+  Fooooooooooooooooooooo / Baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaar;

testsuite/tests/unparsing/return_stmt/long_breaking_return_expr/test.yaml

@@ -0,0 +1,5 @@
+driver: unparser
+rule: return_stmt
+description: |
+  Test the `ReturnStmt` on the line length limit.
+  It is expected that tit breaks after the `return` keyword.

testsuite/tests/unparsing/subtype_decl/long/input.ada

@@ -0,0 +1 @@
+subtype Foo_Bar_Bar_Foo is Foo_Bar_Bar_Bar_Bar_Bar.Bar_Foo_Foo_Foo_Foo_Foo_Foo_Foo;

testsuite/tests/unparsing/subtype_decl/long/test.out

@@ -0,0 +1,2 @@
+subtype Foo_Bar_Bar_Foo is
+  Foo_Bar_Bar_Bar_Bar_Bar.Bar_Foo_Foo_Foo_Foo_Foo_Foo_Foo;

testsuite/tests/unparsing/subtype_decl/long/test.yaml

@@ -0,0 +1,4 @@
+driver: unparser
+rule: subtype_decl
+description: |
+  Test that a `SubtypeDecl` first breaks before the `f_subtype`

testsuite/tests/unparsing/subtype_decl/short/input.ada

@@ -0,0 +1 @@
+subtype Foo is Bar;

testsuite/tests/unparsing/subtype_decl/short/test.out

@@ -0,0 +1 @@
+subtype Foo is Bar;

testsuite/tests/unparsing/subtype_decl/short/test.yaml

@@ -0,0 +1,4 @@
+driver: unparser
+rule: subtype_decl
+description: |
+  Test that no line breaks are added when the `SubtypeDecl` fits on one line.

testsuite/tests/unparsing/type_def/mod_int_type_def/long/input.ada

@@ -0,0 +1 @@
+type Coloooooooooooooooooooooooooooooooooooooooooooooooooooooooooooor is mod <>;

testsuite/tests/unparsing/type_def/mod_int_type_def/long/test.out

@@ -0,0 +1,2 @@
+type Coloooooooooooooooooooooooooooooooooooooooooooooooooooooooooooor is
+  mod <>;

testsuite/tests/unparsing/type_def/mod_int_type_def/long/test.yaml

@@ -0,0 +1,4 @@
+driver: unparser
+rule: type_decl
+description: |
+  Test the line break before the `ModIntTypeDef`.

testsuite/tests/unparsing/type_def/mod_int_type_def/short/input.ada

@@ -0,0 +1 @@
+type Day is mod <>;

testsuite/tests/unparsing/type_def/mod_int_type_def/short/test.out

@@ -0,0 +1 @@
+type Day is mod <>;

testsuite/tests/unparsing/type_def/mod_int_type_def/short/test.yaml

@@ -0,0 +1,4 @@
+driver: unparser
+rule: type_decl
+description: |
+  Test the a short `ModIntTypeDef` does not break.