Merge branch 'topic/1069' into 'master'

Support all forms of the Warnings pragma

Closes #1069

See merge request eng/libadalang/libadalang!1402

ada/ast.py

@@ -10085,17 +10085,24 @@ def xref_equation():
             ),
 
             Entity.id.name_is('Warnings'),
-            Entity.args.at(1)._.assoc_expr.then(
-                lambda expr: If(
-                    expr.is_a(T.Identifier),
-
-                    expr.sub_equation,
+            Entity.args.logic_all(
+                lambda arg: arg.assoc_expr.then(
+                    lambda expr: If(
+                        expr.is_a(T.Identifier),
+                        If(
+                            expr.cast(T.Identifier)._.name_symbol.any_of(
+                                'On', 'Off', 'GNAT', 'GNATprove'
+                            ),
+                            LogicTrue(),
+                            expr.sub_equation
+                        ),
 
-                    Bind(expr.expected_type_var, Self.std_entity("String"))
-                    & expr.sub_equation
-                    & expr.matches_expected_type
-                ),
-                default_val=LogicTrue()
+                        Bind(expr.expected_type_var, Self.std_entity("String"))
+                        & expr.sub_equation
+                        & expr.matches_expected_type
+                    ),
+                    default_val=LogicTrue()
+                )
             ),
 
             # Pragmas we want to deliberately not resolve, either because there

testsuite/tests/name_resolution/pragma_warnings/test.adb

@@ -0,0 +1,12 @@
+procedure Test is
+   pragma Warnings (GNATprove, On, "a warning");
+   pragma Test_Statement;
+   pragma Warnings (GNAT, Off, "a warning");
+   pragma Test_Statement;
+   pragma Warnings (Off, "a warning");
+   pragma Test_Statement;
+   pragma Warnings (Off);
+   pragma Test_Statement;
+begin
+   null;
+end Test;

testsuite/tests/name_resolution/pragma_warnings/test.out

@@ -0,0 +1,73 @@
+Analyzing test.adb
+##################
+
+Resolving xrefs for node <PragmaNode test.adb:2:4-2:49>
+*******************************************************
+
+Expr: <Id "Warnings" test.adb:2:11-2:19>
+  references:    None
+  type:          None
+  expected type: None
+Expr: <Id "GNATprove" test.adb:2:21-2:30>
+  references:    None
+  type:          None
+  expected type: None
+Expr: <Id "On" test.adb:2:32-2:34>
+  references:    None
+  type:          None
+  expected type: None
+Expr: <Str ""a warning"" test.adb:2:36-2:47>
+  references:    None
+  type:          <ConcreteTypeDecl ["String"] __standard:105:3-105:57>
+  expected type: <ConcreteTypeDecl ["String"] __standard:105:3-105:57>
+
+Resolving xrefs for node <PragmaNode test.adb:4:4-4:45>
+*******************************************************
+
+Expr: <Id "Warnings" test.adb:4:11-4:19>
+  references:    None
+  type:          None
+  expected type: None
+Expr: <Id "GNAT" test.adb:4:21-4:25>
+  references:    None
+  type:          None
+  expected type: None
+Expr: <Id "Off" test.adb:4:27-4:30>
+  references:    None
+  type:          None
+  expected type: None
+Expr: <Str ""a warning"" test.adb:4:32-4:43>
+  references:    None
+  type:          <ConcreteTypeDecl ["String"] __standard:105:3-105:57>
+  expected type: <ConcreteTypeDecl ["String"] __standard:105:3-105:57>
+
+Resolving xrefs for node <PragmaNode test.adb:6:4-6:39>
+*******************************************************
+
+Expr: <Id "Warnings" test.adb:6:11-6:19>
+  references:    None
+  type:          None
+  expected type: None
+Expr: <Id "Off" test.adb:6:21-6:24>
+  references:    None
+  type:          None
+  expected type: None
+Expr: <Str ""a warning"" test.adb:6:26-6:37>
+  references:    None
+  type:          <ConcreteTypeDecl ["String"] __standard:105:3-105:57>
+  expected type: <ConcreteTypeDecl ["String"] __standard:105:3-105:57>
+
+Resolving xrefs for node <PragmaNode test.adb:8:4-8:26>
+*******************************************************
+
+Expr: <Id "Warnings" test.adb:8:11-8:19>
+  references:    None
+  type:          None
+  expected type: None
+Expr: <Id "Off" test.adb:8:21-8:24>
+  references:    None
+  type:          None
+  expected type: None
+
+
+Done.

testsuite/tests/name_resolution/pragma_warnings/test.yaml

@@ -0,0 +1,2 @@
+driver: name-resolution
+input_sources: [test.adb]

user_manual/changes/libadalang/1069.yaml

@@ -0,0 +1,6 @@
+type: bugfix
+title: Fix ``pragma Warnings`` name resolution
+description: |
+  This change fixes a name resolution bug for the pragma `Warnings` by not
+  trying to resolve reserved words such as `On`, `Off`, `GNAT` or `GNATprove`.
+date: 2023-09-08