Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper - Kaylyn Cardella #50

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Paper - Kaylyn Cardella #50

wants to merge 5 commits into from

Conversation

kecardel
Copy link

No description provided.

Copy link

@kaidamasaki kaidamasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

We didn't do a full code review on this project, just on issues that manual testing showed. Overall your code performed well and I only noticed one strange behavior (that I left a comment about). Well done!

response = requests.post(self.url+"/rentals/check-out", json=request_params)

if not response:
return f"=== Error: Invalid ID ==="

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check for more specific errors, since things like being out of inventory can also cause this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants