Rock - Adelaide Nalley #52
Conversation
…es for all 13 options
… working code for 11 of the options, not yet accounting for edge cases
There was a problem hiding this comment.
All right, Adelaide! While there were some errors in the CLI, you made mention of them in comments, which let me know that you were aware, but under time constraints.
What I found was that when creating a new video with blank data, it would break the CLI. One thing we could do to avoid that is make sure the user can't move on until they enter valid data. We could also do that with updating customer, videos, an creating a customer, too.
Lastly, your code in main.py was packed tightly, which made it hard to read. One thing we could do in the future is separate big chunks of code into helper functions and import them from another file.
| #I wrote URL instead of TaskList. is that right? | ||
| video_store = URL(url="BACKUP_URL") |
There was a problem hiding this comment.
Based on how I read this program, URL is a constant variable, not a model. So we can't create an instance of URL. I think you should still be using VideoStore, not TaskList or URL
| @@ -0,0 +1,121 @@ | |||
| import requests | |||
| import datetime | |||
| from flask import json | |||
There was a problem hiding this comment.
since this is a front-end CLI that simply interacts with the user in the terminal, we don't need to bring in flask, which is a backend framework. the .json() method is part of the requests module we've imported
| from flask import json |
No description provided.