Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock - Abigail C. #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rock - Abigail C. #53

wants to merge 1 commit into from

Conversation

ChaAbby
Copy link

@ChaAbby ChaAbby commented May 29, 2021

No description provided.

Copy link

@spitsfire spitsfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Abby! A couple of things: remember to play test your CLI to find errors in your options. Sometimes it can be hard to think like a user when you know what the correct inputs should be. But when I input blank data to create a video, the CLI broke.

While this is an error on the API side, something we could do is use try-except to check the final response. Or, another solution is to check that the user put something into the CLI. If left blank, we can prompt the user again to enter data before sending the request.

User experience wise, think about repeating the menu of options more often, so the user doesn't have to scroll back up to find the next them.

Other than that, you completed the project! Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants