Increase max faces FacePrioritySorter #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explorer Ring tele animation has 693 faces, 512 isn't enough and cased index oob.
|
I've looked into this. This happens on normal GPU too, and is a result of project() using a more precise floating point projection than what vanilla uses. The difference is the exception is caught and eaten by the client there. I will probably add a similar try/catch here, but I may also raise the face limit due to this. I don't know if cpu-sorting players like this will be the final approach for rendering players. This plugin is synced off of a local branch I have with other changes and so it is hard to take prs directly to it. |
|
I threw a try/catch around this for now 54af55e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explorer Ring teleport animation has 693 faces, 512 isn't enough and causes a crash due to index OOB.