Skip to content

Commit

Permalink
Respect 'Say all on page load' in PowerPoint slide shows (nvaccess#17488
Browse files Browse the repository at this point in the history
)

Summary of the issue:
When Browse mode setting "say all on page load" is disabled, NVDA yet starts say all in a slide show.

Description of user facing changes
NVDA no longer automatically starts say all when starting a PowerPoint slide show and "say all on page load" is disabled.

Description of development approach
Check the config setting.
  • Loading branch information
LeonarddeR authored Dec 10, 2024
1 parent 7dbe36d commit a94f069
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 3 additions & 0 deletions source/appModules/powerpnt.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import ctypes

import comtypes.client.lazybind
import config
import oleacc
import comHelper
import ui
Expand Down Expand Up @@ -1386,8 +1387,10 @@ def __contains__(self, obj):
def event_treeInterceptor_gainFocus(self):
braille.handler.handleGainFocus(self)
self.rootNVDAObject.reportFocus()
doSayAll = not self.hadFocusOnce and config.conf["virtualBuffers"]["autoSayAllOnPageLoad"]
if not self.hadFocusOnce:
self.hadFocusOnce = True
if doSayAll:
self.reportNewSlide()
else:
info = self.selection
Expand Down
3 changes: 2 additions & 1 deletion user_docs/en/changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,10 @@ To use this feature, "allow NVDA to control the volume of other applications" mu
* Math reading has been fixed for some web elements.
Specifically, MathML inside of span and other elements that have the attribute `role="math"`. (#15058)
* Native support for the Dot Pad tactile graphics device from Dot Inc as a multiline braille display. (#17007)
* Improvements when editing in Microsoft PowerPoint:
* Improvements in Microsoft PowerPoint:
* Caret reporting no longer breaks when text contains wide characters, such as emoji. (#17006 , @LeonarddeR)
* Character location reporting is now accurate (e.g. when pressing `NVDA+Delete`. (#9941, @LeonarddeR)
* NVDA no longer starts say all when starting a slide show and the browse mode setting "Automatic Say All on page load" is disabled. (#17488, @LeonarddeR)
* When using the Seika Notetaker, space and space with dots gestures are now displayed correctly in the Input Gestures dialog. (#17047, @school510587)
* Configuration profiles:
* Braille is no longer dysfunctional when activating 'say all' with an associated configuration profile. (#17163, @LeonarddeR)
Expand Down

0 comments on commit a94f069

Please sign in to comment.