[pull] master from nvaccess:master #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Follow up to #16767, #16803 Preparation for #16852 Summary of the issue: Pre-commit touches several files it shouldn't touch, e.g. symbol dictionaries, translated markdown. Description of user facing changes None Description of development approach Update Ruff to 0.5.2 in requirements Add a hook for scons source Update sconstruct to automatically use the max number of cores when passing -j 0, which can be used with pre-commit to have optimal performance Run pre-commit autoupdate
Fixes #16933 Summary of the issue: If any non-daemon threads remain when NvDA restarts, the new NVDA instance can be very unstable, including freezing and lack of functionality. Description of user facing changes NVDA is no longer unstable after restarting NvDA during a Braille Bluetooth scan. Description of development approach Before releasing the mutex in nvda.pyw, log and join all remaining non-daemon threads.
Run pre-commit on all files
Part of #10516 Summary of the issue: As a developer, I would like automation tools to fix the lint of my code when I open a PR. After #16936, we have applied pre-commit on all files. However, there are no automation checks for some of these checks (like whitespaces changes). Which means without running pre-commit automatically, the repository may have pre-commit regressions. Description of user facing changes Improved documentation for pre-commit hooks and the PR contribution process. Description of development approach Setup Pre-commit CI. This is a CI/CD tool to automatically apply pre-commit to PRs.
Fixes #16806 Summary of the issue: Opening browsable messages can sometimes fail. The underlying issue is that this requires a COM Interface wrapper that is not bundled with NVDA. It will therefore be created on the fly and stored in %temp%\comtypes_cache\nvda-311 Description of user facing changes No crashes, no creation of these modules in temp folder. Description of development approach Added the interface definition to comInterfaces_sconscript Testing strategy: Run from source. Ensure that .venv\Lib\site-packages\comtypes\gen won't be populated with Scripting.py and _420B2830_E718_11CF_893D_00A0C9054228_0_1_0.py Run a portable copy. Ensure that %temp%\comtypes_cache\nvda-311 won't be populated with Scripting.py and _420B2830_E718_11CF_893D_00A0C9054228_0_1_0.py
From translation svn revision: 82936 Authors: Zahari Yurukov <[email protected]> Kostadin Kolev <[email protected]> Stats: 2 0 user_docs/bg/changes.md 1 file changed, 2 insertions(+)
From translation svn revision: 82936 Authors: Daniel K. Gartmann <[email protected]> Nicolai Svendsen <[email protected]> [email protected] Stats: 13 1 source/locale/da/gestures.ini 3 0 source/locale/da/symbols.dic 2 0 user_docs/da/changes.md 3 files changed, 18 insertions(+), 1 deletion(-)
From translation svn revision: 82936 Authors: Bernd Dorer <[email protected]> David Parduhn <[email protected]> Rene Linke <[email protected]> Adriani Botez <[email protected]> Karl Eick <[email protected]> Robert Hänggi <[email protected]> Astrid Waldschmetterling <[email protected]> Stats: 3 1 user_docs/de/changes.md 1 file changed, 3 insertions(+), 1 deletion(-)
From translation svn revision: 82936 Authors: Juan C. buno <[email protected]> Noelia Martinez <[email protected]> Remy Ruiz <[email protected]> Jose M. Delicado <[email protected]> Stats: 2 0 user_docs/es/changes.md 1 file changed, 2 insertions(+)
From translation svn revision: 82936 Authors: Ali Aslani <[email protected]> Mohammadreza Rashad <[email protected]> Stats: 2 0 user_docs/fa/changes.md 1 file changed, 2 insertions(+)
From translation svn revision: 82936 Authors: Jani Kinnunen <[email protected]> Isak Sand <[email protected]> Stats: 4 2 user_docs/fi/changes.md 1 file changed, 4 insertions(+), 2 deletions(-)
From translation svn revision: 82936 Authors: Michel such <[email protected]> Remy Ruiz <[email protected]> Abdelkrim Bensaid <[email protected]> Cyrille Bougot <[email protected]> Corentin Bacque-Cazenave <[email protected]> Sylvie Duchateau <[email protected]> Sof <[email protected]> Stats: 2 0 user_docs/fr/changes.md 1 file changed, 2 insertions(+)
From translation svn revision: 82936 Authors: Juan C. buno <[email protected]> Ivan Novegil <[email protected]> Javier Curras <[email protected]> Jose M. Delicado <[email protected]> Stats: 2 0 user_docs/gl/changes.md 1 file changed, 2 insertions(+)
From translation svn revision: 82936 Authors: Hrvoje Katic <[email protected]> Zvonimir Stanecic <[email protected]> Milo Ivir <[email protected]> Dejana Rakic <[email protected]> Stats: 2 0 user_docs/hr/changes.md 3 5 user_docs/hr/userGuide.md 2 files changed, 5 insertions(+), 5 deletions(-)
From translation svn revision: 82936 Authors: Simone Dal Maso <[email protected]> Alberto Buffolino <[email protected]> Stats: 100 12 user_docs/it/userGuide.md 1 file changed, 100 insertions(+), 12 deletions(-)
From translation svn revision: 82936 Authors: Patryk Faliszewski <[email protected]> Zvonimir Stanecic <[email protected]> Dorota Krac <[email protected]> Piotr Rakowski <[email protected]> Hubert Meyer <[email protected]> Arkadiusz Swietnicki <[email protected]> Stats: 8 6 user_docs/pl/changes.md 1 file changed, 8 insertions(+), 6 deletions(-)
From translation svn revision: 82936 Authors: Zvonimir Stanecic <[email protected]> Aleksandr Lin'kov <[email protected]> Stats: 8 6 user_docs/ru/changes.md 23 23 user_docs/ru/userGuide.md 2 files changed, 31 insertions(+), 29 deletions(-)
From translation svn revision: 82936 Authors: Ondrej Rosik <[email protected]> Peter Vagner <[email protected]> Jan Kulik <[email protected]> Stats: 115 27 user_docs/sk/userGuide.md 1 file changed, 115 insertions(+), 27 deletions(-)
From translation svn revision: 82936 Authors: Nikola Jovic <[email protected]> Janko Valencik <[email protected]> Zvonimir <[email protected]> Danijela Popovic <[email protected]> Stats: 2 0 user_docs/sr/changes.md 1 file changed, 2 insertions(+)
From translation svn revision: 82936 Authors: Cagri Dogan <[email protected]> Stats: 3 1 user_docs/tr/changes.md 1 file changed, 3 insertions(+), 1 deletion(-)
From translation svn revision: 82936 Authors: Volodymyr Pyrig <[email protected]> Stats: 104 0 user_docs/uk/changes.md 1 file changed, 104 insertions(+)
From translation svn revision: 82936 Authors: Dang Hoai Phuc <[email protected]> Nguyen Van Dung <[email protected]> Stats: 2 0 user_docs/vi/changes.md 4 4 user_docs/vi/userGuide.md 2 files changed, 6 insertions(+), 4 deletions(-)
From translation svn revision: 82936
Fixup for #16868 Summary of the issue: As part of #16868, i intended to implement support to pass a number of 0 cores to scons (e.g. scons source -j0) to automatically pick all available cores. It turns out that you cant override an option with SetOption when set on the command line. Description of user facing changes None, build system related. Description of development approach Added an --all-cores parameter that will pick all available cores.
The current auto-deprecation process causes API breakages when we branch for the next release, e.g. the start of the 2025.1 release cycle. When we upgrade `BACK_COMPAT_TO` add-ons begin to receive API breakage warnings. Generally we want to update `BACK_COMPAT_TO` before any API breaking changes. Sometimes we may start the 20XX.1 release cycle, updating `version_year` before we update `BACK_COMPAT_TO`. This causes API deprecations to break before add-ons are declared as incompatible. Description of user facing changes None Description of development approach minor fix up to existing deprecation pending removal
Closes #16895 Summary of the issue: NVDA should have an option to indicate paragraphs in braille, so that reading, especially books or long pieces of text, can be more comfortable and meaningful. Description of user facing changes In the braille settings panel, a new combo box can be used for setting NVDA to show two spaces, a pilcrow or no marker at the start of paragraphs in braille. This requires that the reading by paragraph checkbox is enabled. Description of development approach A new option for this feature has been added in the braille section of config.conf. In config["braille"], an integer is assigned to get the startParagraphMarker. A getParagraphStartMarker function has been added, so that it can be used in different places of braille.py, and in this way we can also make the PILCROW translatable. In the getFormatFieldBraille function of braille.py: when the isAtStart parameter is True, NVDA will check if it's configured to read by paragraph and if it should present the start paragraph indicator, through the getParagraphStartMarker function. In the _set_windowEndPos function of braille.py: if the braille wrap word and paragraph start options are enabled, and the start window pos to be set is minor than or equal to the lenghts of paragraph start indicator + 1 (1 corresponding to the text separator), tart pos is set to the start position of the last region if it starts with paragraph start indicator plus text separator. This handles some cases where the paragraph start indicator is not displayed when the braille word wrap is enabled. The braille settings subpanel has been updated in the gui. A new ParagraphStartMarker class has been added to configFlags.py
…16944) Improves fix for #16933 Improves upon pr #16934 Summary of the issue: In PR #16934, it was ensured that NVDA's mutex would not be released until all remaining non-daemon threads were joined and completed. Otherwise, the NVDA process may stay around because of remaining background threads, such as the Braille auto detector worker thread. However, the joining of the threads was done after NVDA's message window was destroyed, therefore making it impossible for a new instance of NVDA to locate and kill off the old NVDA if it truly was taking way too long. Description of user facing changes An old NvDA has more chance of being killed off if it is taking too long to exit when a new copy of NVDA is trying to start. Description of development approach Move the joining of the non-daemon threads out of nvda.pyw, and into the bottom of core.main. Also ensure that destroying the message window is the very last action taken. So the ordering of the end of core.main is now: terminate all subsystems Join threads destroy the message window.
closes #10344 Summary of the issue: In the developer's guide, the code blocks have been reworked by adding "py" tags and by removing indentation spaces and on empty lines. String types of % have also been converted to f-string type. Description of user facing changes In the developer guide, the user will see a new appearance of code blocks, with the string characters % replaced with string characters f, indentations by removed spaces, and py tags present at each block.
…symbol definition, the symbol replacement is spoken (#16950) Fixup for #16622 Summary of the issue: When unicode normalization of a character (e.g. ·) resulted into a character that had a symbol definition (e.g. ·, middle dot), the symbol definition wasn't applied to the normalization. This resulted in NVDA speaking nothing or only the word normalized. Description of user facing changes NVDA will now properly speak the · character (Greek Ano Teleia) as middle dot when normalizing. This also applies to other characters where normalization results in a character that's part of the symbol dictionary. Description of development approach When normalizing a character, ensure it is thrown through characterProcessing.processSpeechSymbol.
Beta to l10n
From translation svn revision: 82968 Authors: Takuya Nishimoto <[email protected]> Minako Nonogaki <[email protected]> Stats: 2 0 user_docs/ja/changes.md 1 file changed, 2 insertions(+)
From translation svn revision: 82968 Authors: Diogo Costa <[email protected]> Rui Batista <[email protected]> Rui Fontes <[email protected]> Ângelo Abrantes <[email protected]> Stats: 100 0 user_docs/pt_PT/changes.md 124 36 user_docs/pt_PT/userGuide.md 2 files changed, 224 insertions(+), 36 deletions(-)
From translation svn revision: 82968 Authors: Zvonimir Stanecic <[email protected]> Aleksandr Lin'kov <[email protected]> Stats: 4 4 user_docs/ru/userGuide.md 1 file changed, 4 insertions(+), 4 deletions(-)
From translation svn revision: 82968 Authors: Nikola Jovic <[email protected]> Janko Valencik <[email protected]> Zvonimir <[email protected]> Danijela Popovic <[email protected]> Stats: 4 4 user_docs/sr/userGuide.md 1 file changed, 4 insertions(+), 4 deletions(-)
From translation svn revision: 82968 Authors: Dinakar T.D. <[email protected]> Stats: 7 7 user_docs/ta/userGuide.md 1 file changed, 7 insertions(+), 7 deletions(-)
From translation svn revision: 82968 Authors: [email protected] [email protected] Aaron Wu <[email protected]> Victor Cai <[email protected]> [email protected] Stats: 199 145 source/locale/zh_TW/characterDescriptions.dic 1 file changed, 199 insertions(+), 145 deletions(-)
From translation svn revision: 82968
Update translations
Beta to master
NV Access has a server side script to automatically assign milestones to closed issues and PRs. This script has been malfunctioning for some time meaning we are not tracking which release issues are closed in. Description of development approach Used copilot to generate a github action to assign milestones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )