improv: reduce amount of request when fetching pokemons

AdrienGiboire · Oct 13, 2021 · 23926da · 23926da
1 parent 6757c92
commit 23926da
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/controllers/api/pokemons_controller.rb b/app/controllers/api/pokemons_controller.rb
@@ -1,6 +1,6 @@
 class Api::PokemonsController < ApplicationController
   def index
-    render json: Pokemon.all, include: ['types']
+    render json: Pokemon.preload(:pokemon_types, :types).all, include: ['types']
   end
 
   def show

diff --git a/app/serializers/pokemon_serializer.rb b/app/serializers/pokemon_serializer.rb
@@ -13,7 +13,7 @@ class PokemonSerializer < ActiveModel::Serializer
   has_many :types do
     object.types.map do |type|
       TypeSerializer.new(type).serializable_hash.merge(
-        slot: PokemonType.where(type_id: type.id, pokemon_id: object.id).first.slot
+        slot: object.pokemon_types.where(type_id: type.id).first.slot
       )
     end
   end