Skip to content

Commit

Permalink
feat: Bump minimum supported Flutter SDK >= 3.7.0 (#2001)
Browse files Browse the repository at this point in the history
We need this
change(flutter/engine@90815e5),
which was released in Flutter SDK 3.7.0 to fix a crash on
Windows(#1999)

This PR is preparing for the fix.
  • Loading branch information
littleGnAl committed Sep 13, 2024
1 parent 3dcac88 commit a596641
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 18 deletions.
19 changes: 9 additions & 10 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ jobs:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci:skip') }}
strategy:
matrix:
version: ["2.10.5", "3.x"]
runs-on: macos-12
version: ["3.7.0", "3.x"]
runs-on: ubuntu-latest
timeout-minutes: 120
env:
TEST_APP_ID: ${{ secrets.MY_APP_ID }}
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci:skip') }}
strategy:
matrix:
version: ["2.10.5", "3.x"]
version: ["3.7.0", "3.16"]
runs-on: macos-12
timeout-minutes: 120
env:
Expand All @@ -136,7 +136,7 @@ jobs:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci:skip') }}
strategy:
matrix:
version: ["2.10.5", "3.x"]
version: ["3.7.0", "3.x"]
runs-on: macos-12
timeout-minutes: 120
env:
Expand All @@ -155,8 +155,7 @@ jobs:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci:skip') }}
strategy:
matrix:
# Pin Flutter SDK version to 3.19, since there's issue with 3.22.x, see https://github.com/AgoraIO-Extensions/Agora-Flutter-SDK/actions/runs/9186647960/job/25262717666
version: ["2.10.5", "3.19"]
version: ["3.7.0", "3.x"]
runs-on: windows-2019
timeout-minutes: 120
env:
Expand Down Expand Up @@ -201,7 +200,7 @@ jobs:
needs: flutter_codestyle_check
strategy:
matrix:
version: ["2.10.5", "3.x"]
version: ["3.7.0", "3.x"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -221,7 +220,7 @@ jobs:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci:skip') }}
strategy:
matrix:
version: ["2.10.5", "3.x"]
version: ["3.7.0", "3.x"]
runs-on: windows-2019
steps:
- uses: actions/checkout@v3
Expand All @@ -242,7 +241,7 @@ jobs:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci:skip') }}
strategy:
matrix:
version: ["2.10.5", "3.x"]
version: ["3.7.0", "3.x"]
runs-on: macos-12
timeout-minutes: 120
steps:
Expand Down Expand Up @@ -287,7 +286,7 @@ jobs:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci:skip') }}
strategy:
matrix:
version: ["2.10.5", "3.x"]
version: ["3.7.0", "3.x"]
runs-on: ubuntu-latest
timeout-minutes: 120
steps:
Expand Down
2 changes: 1 addition & 1 deletion example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ description: Demonstrates how to use the agora_rtc_engine plugin.
publish_to: 'none' # Remove this line if you wish to publish to pub.dev

environment:
sdk: ">=2.16.1 <3.0.0"
sdk: ">=2.19.0 <4.0.0"

# Dependencies specify other packages that your package needs in order to work.
# To automatically upgrade your package dependencies to the latest versions
Expand Down
4 changes: 2 additions & 2 deletions test_shard/fake_test_app/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
version: 1.0.0+1

environment:
sdk: '>=2.14.0 <3.0.0'
flutter: '>=2.0.0'
sdk: '>=2.19.0 <4.0.0'
flutter: '>=3.7.0'

# Dependencies specify other packages that your package needs in order to work.
# To automatically upgrade your package dependencies to the latest versions
Expand Down
3 changes: 2 additions & 1 deletion test_shard/integration_test_app/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
version: 1.0.0+1

environment:
sdk: ">=2.14.0 <3.0.0"
sdk: '>=2.19.0 <4.0.0'
flutter: '>=3.7.0'

# Dependencies specify other packages that your package needs in order to work.
# To automatically upgrade your package dependencies to the latest versions
Expand Down
4 changes: 2 additions & 2 deletions test_shard/iris_tester/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ version: 0.0.1
homepage:

environment:
sdk: '>=2.14.0 <3.0.0'
flutter: '>=2.0.0'
sdk: '>=2.19.0 <4.0.0'
flutter: '>=3.7.0'

dependencies:
flutter:
Expand Down
4 changes: 2 additions & 2 deletions test_shard/rendering_test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
version: 1.0.0+1

environment:
sdk: '>=2.14.0 <3.0.0'
flutter: '>=2.0.0'
sdk: '>=2.19.0 <4.0.0'
flutter: '>=3.7.0'

# Dependencies specify other packages that your package needs in order to work.
# To automatically upgrade your package dependencies to the latest versions
Expand Down

0 comments on commit a596641

Please sign in to comment.