Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter Check and DartDoc Upload #1383

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Formatter Check and DartDoc Upload #1383

merged 7 commits into from
Oct 18, 2023

Conversation

maxxfrazer
Copy link
Contributor

  • add dart format to build process
  • upload zipped dartdoc on release

- name: Build DartDoc 📖
run: |
# Generate DartDoc
dart doc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very sure if the action k-paxian/dart-package-publisher@master brings the dart env or not. Maybe we need to test it first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've aded a step to build.yml to attach it to the workflow. If that works, then this one should work the same…

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not the same, in the build.yaml, you have set up the dart env by using the action uses: dart-lang/setup-dart@v1, I think you should also add it here.

@littleGnAl littleGnAl merged commit 4ecea25 into main Oct 18, 2023
32 checks passed
@littleGnAl littleGnAl deleted the attach-doc branch October 18, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants