Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update minSdkVersion to 21 to Fix NDK Compatibility Issue #106

Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix: Update minSdkVersion to 21 to Fix NDK Compatibility Issue #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a3de6d
fix: Update minSdkVersion to 21 to Fix NDK Compatibility Issue
littleGnAl Oct 9, 2024
d5ab45d
++
littleGnAl Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
group 'com.agora.iris_method_channel'
version '1.0'

def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

buildscript {
repositories {
google()
Expand All @@ -27,7 +31,7 @@ android {
namespace 'com.agora.iris_method_channel'
}

compileSdkVersion 31
compileSdkVersion safeExtGet('compileSdkVersion', 31)

externalNativeBuild {
cmake {
Expand All @@ -49,7 +53,7 @@ android {
}

defaultConfig {
minSdkVersion 16
minSdkVersion safeExtGet('minSdkVersion', 21)

externalNativeBuild {
cmake {
Expand Down
2 changes: 1 addition & 1 deletion example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ android {
applicationId "com.agora.iris_method_channel_example"
// You can update the following values to match your application needs.
// For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-build-configuration.
minSdkVersion flutter.minSdkVersion
minSdkVersion 21
targetSdkVersion flutter.targetSdkVersion
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
Expand Down
Loading