-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure package can be built and tested with Python 3.11 #97
Conversation
cb8588c
to
470f7ed
Compare
The linter error is due to pylint-dev/pylint#6535 |
470f7ed
to
b6ff78f
Compare
The unit test error was due to a change to Enum.format behaviour (see https://docs.python.org/3/whatsnew/3.11.html) |
Codecov ReportBase: 76.22% // Head: 75.81% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 76.22% 75.81% -0.41%
==========================================
Files 16 16
Lines 3903 3903
Branches 896 917 +21
==========================================
- Hits 2975 2959 -16
- Misses 714 733 +19
+ Partials 214 211 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
22b7a08
to
ecaedab
Compare
Can we remove support for older python versions too? At least allowing us to use python3.8 syntax would be nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are probably all good, but most of them are not described and mixed together in the same commit, this should be split and explained a little more.
Removing 3.8 and older sounds reasonable. |
ecaedab
to
ea6ef6d
Compare
Python versions pre-3.9 have been deprecated, the PR has been split into smaller commits as requested, and the test matrix was updated to test 3.11 with newer MySQL and Percona Server version.
Python 3.11 was released recently, and myhoard aims to support it.