-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the Readme #469
Improvements to the Readme #469
Conversation
Also removed the mentioning of Mojang Accounts, as those don't really exist anymore. |
Ok, I think I got kinda confused there and would like to clarify. You said that player reporting got added in 1.19.1, then why does NoChatReports have releases for 1.19.0? |
Chat signing was added in 1.19.0. At the time, nobody knew how it would be used and didn't think much of it (as it sounded positive in theory). But when the 1.19.1 snapshots and pre-releases came, NCR was made, including for 1.19 just in case (it was also not known if 1.19.1 users can report 1.19 ones). |
Shouldn't those two say "1.19" then? This mod strips cryptographic signatures which are attached to every chat message sent from Disables Player Chat Reporting from You did say that Player reporting was added in 1.19.1, not 1.19 though |
Yes, 1.19 had signatures that NCR prevents, so you could change it.
However 1.19.1 users could not report 1.19 ones (and vice-versa), so chat reporting was kind of irrelevant there. The 1.19 signatures were just removed as a precaution, not sure how to word that. |
Well, 1.19 users can still report 1.19 users and 1.19.1 ones other >=1.19.1 (1.19.2, .3, .4 and 1.20+) users, right? So maybe something like:
|
1.19 users cannot report anyone, the button, dialogs and other technicalities were added in 1.19.1, hence the controversy there. |
So you're saying that they just added signatures and all just to not give users the ability to even use them? That's.. wow. What about this Disables Chat Reporting from 1.19.1 and onwards |
Well, signing messages generally is a matter of authenticity, so one could assume it to be implemented for a good cause, like a prerequisite for end-to-end encryption, or even just for preventing servers from modifying/spoofing player messages (which was indeed added). Anyway - yes, your suggested paragraph looks fine. |
Is this enough? Didn't want to make it too long.. |
Btw any idea on when this will be merged? |
Right about now 👌 |
Whoops, literally asked 5 minutes before it got merged.... |
Well actually I saw your comment and realized that this is probably ready to be merged, so, like, I merged it 😅 |
This is a bit easier to read and makes it a bit "smoother"
I have also made the "Configuration" part it's own section, to give people an easy to find and short explanation of what each file does.
For some reason GitHub makes my changes look big, which is not the case.