Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollState value #841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tl-94
Copy link

@tl-94 tl-94 commented Nov 10, 2023

Description

Fix scrollState value;
In getScroll funtion, the start value will always be zero if start < 0, although the start is less than size(window.innerHeight if vertical), the problem is:
if there's a virtual list below the viewport, then scroll the virtual list to the middle of the viewport, you will see there're blank rows(only rendered buffer items), because the start value is still zero, so positionDiff will be zero, then updateVisibleItems function will be return, blank rows appeared.
so i changed the condition, don't set start to zero if bounds.top(if vertical) is great than 0 and less than size, that means the scroll list is entering the viewport, need to recalculate the startIndex and endIndex, so that blank rows will be disappeared and render real items.

Reproduction
Demo site

  1. scroll the virtual list under the viewport to the middle of the viewport
  2. you will see there're blank rows

Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for vue-virtual-scroller-demo failed.

Name Link
🔨 Latest commit dd47289
🔍 Latest deploy log https://app.netlify.com/sites/vue-virtual-scroller-demo/deploys/654d99914d2693000840704c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant