Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: update error icons #251

Merged
merged 1 commit into from
May 9, 2024
Merged

perf: update error icons #251

merged 1 commit into from
May 9, 2024

Conversation

michelle-alaskaair
Copy link

@michelle-alaskaair michelle-alaskaair commented Apr 30, 2024

This commit will update the filled and stroke error icons to increase the size for better consistency

Changes to be committed:
modified: src/icons/error-filled.svg
modified: src/icons/error-stroke.svg

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #248

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

BEFORE:
Screenshot 2024-05-09 at 12 30 38 PM

AFTER:
Screenshot 2024-05-09 at 12 32 27 PM

Type of change:

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Update existing icons

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

This commit will update the filled and stroke error
icons to increase the size for better consistency

Changes to be committed:
modified:   src/icons/error-filled.svg
modified:   src/icons/error-stroke.svg
@michelle-alaskaair michelle-alaskaair self-assigned this Apr 30, 2024
@michelle-alaskaair michelle-alaskaair requested a review from a team as a code owner April 30, 2024 23:17
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Michelle Noelke seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@michelle-alaskaair michelle-alaskaair linked an issue May 1, 2024 that may be closed by this pull request
@blackfalcon blackfalcon removed the icons label May 9, 2024
@blackfalcon blackfalcon self-requested a review May 9, 2024 19:23
@blackfalcon
Copy link
Member

Latest build published:

http://alaska.iconstails.surge.sh/

@blackfalcon blackfalcon merged commit 1792225 into master May 9, 2024
3 of 4 checks passed
@blackfalcon blackfalcon deleted the mnoelke/newErrorIcons/248 branch May 9, 2024 19:35
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.41.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to error icon
3 participants