-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new logo icons #259
Add new logo icons #259
Conversation
5d6e9c7
to
c9511a5
Compare
Reviewer's Guide by SourceryThis pull request updates the logo icons data and modifies the TypeScript configuration. The changes include adding new partner logo icons, updating existing ones, and adjusting the TypeScript compiler options for better compatibility and performance. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you provide more context on the changes made to tsconfig.json? Specifically, why was the 'include' path changed from 'dist//*.js' to 'src//*.js', and what are the implications of updating the target to 'ES2022' and adding 'moduleResolution: node'?
- The logo icon updates look comprehensive. Have these new logos been optimized for file size, and are all of them necessary for the current project requirements?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
c9511a5
to
2f2d513
Compare
🎉 This PR is included in version 4.43.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #252, #260
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Add new partner logo icons and update existing ones with revised dimensions. Update TypeScript configuration to process source JavaScript files and target ES2022.
New Features:
Enhancements:
Build: