Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new logo icons #259

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Add new logo icons #259

merged 3 commits into from
Aug 26, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Aug 5, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #252, #260

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Add new and edit existing partner logo icons
  • Add hazard icons
  • Update dependencies

Type of change:

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Add new partner logo icons and update existing ones with revised dimensions. Update TypeScript configuration to process source JavaScript files and target ES2022.

New Features:

  • Add new partner logo icons for various airlines including Cape Air, Mokulele Airlines, Royal Air Maroc, Porter Airlines, Iberia, Kenmore Air, Malaysia Airlines, Royal Jordanian, Southern Airways Express, Air Tahiti Nui, SriLankan Airlines, Bahamasair, Aleutian Airways, and Air Tahiti.

Enhancements:

  • Update existing partner logo icons with new dimensions for airlines such as Ravn Alaska, American Airlines, Cathay Pacific, Emirates, Fiji Airways, Korean Airlines, LATAM Airlines, Qantas, Singapore Airlines, Japan Airlines, Hainan Airlines, FinnAir, British Airways, Condor, Aer Lingus, Icelandair, and Israel Airlines.

Build:

  • Update TypeScript configuration to include source JavaScript files instead of distribution files and set the target to ES2022 with node module resolution.

@jordanjones243 jordanjones243 self-assigned this Aug 5, 2024
This was linked to issues Aug 5, 2024
@jordanjones243 jordanjones243 marked this pull request as ready for review August 16, 2024 16:05
@jordanjones243 jordanjones243 requested a review from a team as a code owner August 16, 2024 16:05
Copy link

sourcery-ai bot commented Aug 16, 2024

Reviewer's Guide by Sourcery

This pull request updates the logo icons data and modifies the TypeScript configuration. The changes include adding new partner logo icons, updating existing ones, and adjusting the TypeScript compiler options for better compatibility and performance.

File-Level Changes

Files Changes
src/data/logoIcons.json Added new partner logo icons for Cape Air, Mokulele Airlines, Royal Air Maroc, Porter Airlines, and Japan Airlines (JX)
src/data/logoIcons.json Updated viewBox dimensions for existing partner logo icons to improve rendering and consistency
src/data/logoIcons.json Added several new partner logo icons including Kenmore Air, Malaysia Airlines, Royal Jordanian, Southern Airways Express, Air Tahiti Nui, SriLankan Airlines, Bahamasair, Aleutian Airways, and Air Tahiti
tsconfig.json Modified TypeScript configuration to process source JS files instead of generated files
tsconfig.json Updated TypeScript compiler options to target ES2022 and use node module resolution

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@jordanjones243 jordanjones243 linked an issue Aug 16, 2024 that may be closed by this pull request
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you provide more context on the changes made to tsconfig.json? Specifically, why was the 'include' path changed from 'dist//*.js' to 'src//*.js', and what are the implications of updating the target to 'ES2022' and adding 'moduleResolution: node'?
  • The logo icon updates look comprehensive. Have these new logos been optimized for file size, and are all of them necessary for the current project requirements?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@jordanjones243 jordanjones243 changed the title Add new logo and hazard icons Add new logo icons Aug 19, 2024
@jordanjones243 jordanjones243 linked an issue Aug 23, 2024 that may be closed by this pull request
@jordanjones243 jordanjones243 merged commit 8cb3a67 into master Aug 26, 2024
4 checks passed
@jordanjones243 jordanjones243 deleted the jjones/newIcons branch August 26, 2024 16:36
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tail logo - Oman Air Add partner logos to icon repo
3 participants