Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requested icons #266

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Add requested icons #266

merged 2 commits into from
Oct 8, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Oct 7, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #262, #263

Type of change:

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Introduce new icons related to dollar signs and editing tools, and enhance descriptions for existing icons to improve clarity.

New Features:

  • Add new icons including 'dollar-sign-filled', 'dollar-sign-stroke', 'dollar-sign-sm', 'dollar-sign-lg', 'edit-stroke', and 'edit-filled' to the icon set.

Enhancements:

  • Update descriptions for existing icons 'checkmark-lg', 'checkmark-sm', 'x-lg', and 'x-sm' to provide more clarity.

@jordanjones243 jordanjones243 self-assigned this Oct 7, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner October 7, 2024 21:16
Copy link

sourcery-ai bot commented Oct 7, 2024

Reviewer's Guide by Sourcery

This pull request adds new icons and updates descriptions for existing icons in the icons.json file. The changes include adding dollar sign and edit icons, as well as updating descriptions for checkmark and x icons.

Entity Relationship Diagram for Updated Icons

erDiagram
    ICON {
        string name
        string desc
        string category
        boolean deprecated
    }

    ICON ||--o{ ICONS : contains

    ICONS {
        ICON checkmark-lg
        ICON checkmark-sm
        ICON dollar-sign-filled
        ICON dollar-sign-stroke
        ICON dollar-sign-sm
        ICON dollar-sign-lg
        ICON edit-stroke
        ICON edit-filled
        ICON x-lg
        ICON x-sm
    }
Loading

File-Level Changes

Change Details Files
Added new dollar sign icons
  • Added 'dollar-sign-filled' icon
  • Added 'dollar-sign-stroke' icon
  • Added 'dollar-sign-sm' icon
  • Added 'dollar-sign-lg' icon
src/data/icons.json
Added new edit icons
  • Added 'edit-stroke' icon
  • Added 'edit-filled' icon
src/data/icons.json
Updated descriptions for existing icons
  • Updated description for 'checkmark-lg' icon
  • Updated description for 'checkmark-sm' icon
  • Added description for 'x-lg' icon
  • Added description for 'x-sm' icon
src/data/icons.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jason-capsule42 jason-capsule42 merged commit fec3dc0 into master Oct 8, 2024
4 checks passed
@jason-capsule42 jason-capsule42 deleted the jjones/addNewIcons branch October 8, 2024 15:46
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace icons - x-sm, x-lg, check-lg New icons – dollar-sign, edit
3 participants