Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate data reference #269 #270

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

blackfalcon
Copy link
Member

@blackfalcon blackfalcon commented Oct 16, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #269

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Removes incorrectly duplicated data reference.

Type of change:

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Bug Fixes:

  • Remove duplicate data reference for Finnair airplane tail image in logoIcons.json.

On branch dsande/dupDataRef/269
Changes to be committed:
modified:   src/data/logoIcons.json
@blackfalcon blackfalcon self-assigned this Oct 16, 2024
@blackfalcon blackfalcon linked an issue Oct 16, 2024 that may be closed by this pull request
@blackfalcon blackfalcon marked this pull request as ready for review October 16, 2024 22:03
@blackfalcon blackfalcon requested a review from a team as a code owner October 16, 2024 22:03
Copy link

sourcery-ai bot commented Oct 16, 2024

Reviewer's Guide by Sourcery

This pull request removes a duplicate data reference for the Finnair airplane tail image from the logoIcons.json file. The change is straightforward and involves deleting a single JSON object from an array of logo icon definitions.

Entity Relationship Diagram for logoIcons.json Update

erDiagram
    LOGO_ICON {
        string name
        string title
        string viewBox
    }

    LOGO_ICON }|--|{ LOGO_ICON : contains

    note for LOGO_ICON "Removed duplicate entry for Finnair tail image"
Loading

File-Level Changes

Change Details Files
Removal of duplicate Finnair airplane tail image data
  • Deleted the JSON object for the 'tail-FI' logo icon
  • Removed redundant entry for Finnair airplane tail image
src/data/logoIcons.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @blackfalcon - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jason-capsule42 jason-capsule42 merged commit f1f6e6e into master Oct 16, 2024
4 checks passed
@jason-capsule42 jason-capsule42 deleted the dsande/dupDataRef/269 branch October 16, 2024 22:28
@blackfalcon
Copy link
Member Author

🎉 This PR is included in version 4.44.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated airline tail reference
2 participants