-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sass build tasks check folders recursively, adds support for monorepos #580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit messages need to be updated to match our contribution guidelines (e.g. fix: ...
, feat:...
)
c835b7c
to
8c77000
Compare
🎉 This PR is included in version 4.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
In preparation for
auro-form
becoming a monorepo in #1, updates to the SASSbuild
tasks in Auro component'spackage.json
need to be introduced into thewc-generator
template files./src/
folder to a/components/
folder, requiring search support in build tasksResolves: #579
Summary:
Changes to
package.json
build:sass:component
build:sass:component
command to:sass:render
Updated
sass:render
to check recursively, and added the/components/
folder:sweep
run sweep
command to check recursively./components
folderTesting
Tested in two repositories:
auro-input
auro-radio
Process
Made the changes to
package.json
in the local copy of the respective repositories.Ran
npm run build
which ran thebuild:sass
task:Confirming changes
npm run sweep
, any previous.css
&.js
files are cleaned from the reponpm run build
and observed the expected files being built:auro-input
/src/
to further check recursive functionality:Exit notes
Some legacy components, such as
auro-input
, may require their SASS build tasks to be manually updated. See AlaskaAirlines/auro-library#69 for details.Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team