Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #82

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and update CI configurations.

Enhancements:

  • Update contributing guidelines with Conventional Commits and rebasing best practices.
  • Remove graphiteWidth option for performance reasons.
  • Update repository settings and labels.

CI:

  • Update node version to v22 in CI tests.

Tests:

  • Update test matrix to use Node.js v20 and v22.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:45
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the project to use Node.js v22 and introduces Conventional Commits.

Sequence diagram for Conventional Commits workflow

sequenceDiagram
    actor D as Developer
    participant G as Git
    participant CI as CI/CD Pipeline
    participant S as Semantic Version

    D->>G: Make code changes
    D->>G: Commit with conventional format<br/>(type(scope): message)
    G->>CI: Trigger CI pipeline
    CI->>S: Analyze commit message
    alt Major Change
        S->>CI: Detect BREAKING CHANGE
        CI->>G: Bump major version (X.0.0)
    else Feature
        S->>CI: Detect feat prefix
        CI->>G: Bump minor version (0.X.0)
    else Fix/Performance
        S->>CI: Detect fix/perf prefix
        CI->>G: Bump patch version (0.0.X)
    end
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated Node.js version to 22.x in the test and publish workflow.
  • Updated Node.js version to 22.x in package.json.
  • Regenerated package-lock.json.
  • Updated the test matrix in the settings file to use Node.js versions 20.x and 22.x.
.github/workflows/testPublish.yml
package.json
package-lock.json
.github/settings.yml
Introduced Conventional Commits
  • Added information about Conventional Commits and commit message formatting to CONTRIBUTING.md.
.github/CONTRIBUTING.md
Added a workflow to publish a demo on pull requests to the main branch
  • Created a new workflow file to publish a demo on pull requests targeting the main branch.
.github/workflows/publishDemo.yml
Updated repository settings
  • Removed the repository description.
  • Updated repository topics.
.github/settings.yml
Updated documentation and templates
  • Minor updates to the contributing guidelines.
  • Minor updates to the code of conduct.
  • Minor updates to the stale configuration file.
  • Minor updates to the pull request template.
  • Minor updates to the CodeQL workflow file.
  • Minor updates to the CODEOWNERS file.
  • Added new issue templates.
  • Removed old issue templates.
.github/CONTRIBUTING.md
.github/CODE_OF_CONDUCT.md
.github/stale.yml
.github/PULL_REQUEST_TEMPLATE.md
.github/workflows/codeql.yml
.github/CODEOWNERS
.github/ISSUE_TEMPLATE/bug_report.yml
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

github-actions bot commented Dec 20, 2024

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.github/stale.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@rmenner rmenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge #81

sun-mota
sun-mota previously approved these changes Dec 20, 2024
@jason-capsule42 jason-capsule42 force-pushed the migration/package-update/node-v22 branch from 4d19048 to 662ab09 Compare December 22, 2024 19:12
@jason-capsule42 jason-capsule42 merged commit bebcadc into main Dec 22, 2024
6 of 7 checks passed
@jason-capsule42 jason-capsule42 deleted the migration/package-update/node-v22 branch December 22, 2024 19:16
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
4 participants