-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AURO MIGRATION: Update node to v22 #153
Conversation
Reviewer's Guide by SourceryThis pull request updates the project to use Node.js version 22 and introduces several improvements to the repository settings, workflow, and contribution guidelines. State diagram for branch protection changesstateDiagram-v2
state "Branch Protection Rules" as BP {
state "Required Status Checks" as RSC {
[*] --> test18x: Before
[*] --> test20x: Before
[*] --> test20x_new: After
[*] --> test22x: After
test18x --> [*]: Removed
test20x --> [*]: Before
test20x_new --> [*]: After
test22x --> [*]: After
}
state "Branch Names" as BN {
[*] --> master: Before
[*] --> main: After
master --> main: Renamed
}
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The Node.js version specification in package.json should be
^20 || ^22
rather than^20.x || ^22.x
- the.x
is redundant and not a standard format
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Resolves AlaskaAirlines/auro-templates#6
Summary by Sourcery
Update Node to v22 and make associated project configuration changes.
Build:
CI:
Documentation:
Tests: