Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #153

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and make associated project configuration changes.

Build:

  • Update Node to v22.

CI:

  • Update CI to test against Node 20 and 22.

Documentation:

  • Update documentation to reflect Node version change and main branch renaming.

Tests:

  • Update tests to run on Node 22.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:42
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the project to use Node.js version 22 and introduces several improvements to the repository settings, workflow, and contribution guidelines.

State diagram for branch protection changes

stateDiagram-v2
    state "Branch Protection Rules" as BP {
        state "Required Status Checks" as RSC {
            [*] --> test18x: Before
            [*] --> test20x: Before
            [*] --> test20x_new: After
            [*] --> test22x: After
            test18x --> [*]: Removed
            test20x --> [*]: Before
            test20x_new --> [*]: After
            test22x --> [*]: After
        }
        state "Branch Names" as BN {
            [*] --> master: Before
            [*] --> main: After
            master --> main: Renamed
        }
    }
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated the Node.js version in package.json to 20.x
Updated default branch
  • Changed default branch from "master" to "main" in settings.yml
  • Updated references to "master" branch to "main" in workflows and contributing guidelines
.github/CONTRIBUTING.md
.github/settings.yml
.github/workflows/codeql.yml
.github/workflows/publishDemo.yml
.github/workflows/testPublish.yml
Improved contribution guidelines
  • Clarified language around feature requests and bug reports
  • Updated guidance on forking and rebasing
  • Added information about Conventional Commits and commit message formatting
  • Included examples of good commit messages
.github/CONTRIBUTING.md
Updated repository settings
  • Removed repository description
  • Updated repository topics
  • Added team access settings
.github/settings.yml
Updated workflows
  • Updated CodeQL workflow to use "main" branch
  • Updated publishDemo workflow to use "main" branch
  • Updated testPublish workflow to use "main" branch and Node.js versions 20.x and 22.x
.github/workflows/codeql.yml
.github/workflows/publishDemo.yml
.github/workflows/testPublish.yml
Updated stale bot configuration
  • Added additional configuration options for stale bot
.github/stale.yml
Updated pull request template
  • Minor updates to the pull request template
.github/PULL_REQUEST_TEMPLATE.md
Updated code of conduct
  • Minor updates to the code of conduct
.github/CODE_OF_CONDUCT.md
Updated CODEOWNERS file
  • Updated the CODEOWNERS file
.github/CODEOWNERS

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The Node.js version specification in package.json should be ^20 || ^22 rather than ^20.x || ^22.x - the .x is redundant and not a standard format
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jordanjones243 jordanjones243 changed the base branch from master to main December 20, 2024 21:50
@jordanjones243 jordanjones243 merged commit e83ac01 into main Dec 20, 2024
1 check passed
@jordanjones243 jordanjones243 deleted the migration/package-update/node-v22 branch December 20, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
2 participants