Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #142

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and revise contributing guidelines.

Build:

  • Update Node to v22.

CI:

  • Update CI to test on Node 20 and 22.

Documentation:

  • Revise contributing guidelines, including adding Innersource Flow Guide link, updating issue submission process, clarifying feature branch naming, and emphasizing rebasing best practices.

Tests:

  • Update CI tests to run on Node 22.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:45
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the Auro Flight component to use Node.js v22 and introduces several improvements to the contributing guidelines and issue templates.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated Node.js version to v22 in the test and publish workflow.
  • Updated Node.js version to v22 in package.json.
  • Removed Node 18 test in the test and publish workflow.
  • Updated Node.js version to v22 in the codeql workflow.
  • Updated Node.js version to v22 in settings.yml.
.github/workflows/testPublish.yml
package.json
.github/workflows/codeql.yml
.github/settings.yml
Improved contributing guidelines
  • Added a link to the Innersourcing Flow Guide on Sharepoint.
  • Clarified the process for submitting issues and pull requests.
  • Added information about issue and pull request response times.
  • Emphasized the importance of rebasing and provided instructions.
  • Added a section on conventional commits and commit message formatting.
  • Added information about the pull request service level agreement.
.github/CONTRIBUTING.md
Updated issue templates
  • Disabled blank issues.
  • Updated the bug report template to clarify content and request screenshots.
  • Created new feature request and general support templates.
  • Added exit criteria to issue templates.
.github/ISSUE_TEMPLATE/config.yml
.github/ISSUE_TEMPLATE/bug_report.yml
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml
Added new workflows
  • Added a workflow to publish a demo on pull requests to the main branch.
.github/workflows/publishDemo.yml
Updated repository settings
  • Updated repository topics.
  • Added team permissions.
  • Updated stale bot configuration.
  • Updated pull request template.
  • Updated code of conduct.
.github/settings.yml
.github/CODEOWNERS
.github/stale.yml
.github/PULL_REQUEST_TEMPLATE.md
.github/CODE_OF_CONDUCT.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

github-actions bot commented Dec 20, 2024

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@rmenner rmenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge #141

@DukeFerdinand DukeFerdinand force-pushed the migration/package-update/node-v22 branch from 6791b47 to 73fab1f Compare December 23, 2024 19:48
@DukeFerdinand DukeFerdinand dismissed rmenner’s stale review December 23, 2024 20:04

merged in 141 this morning!

@DukeFerdinand
Copy link
Contributor

Merging bypassing rules. Reason: v18 is marked required but no longer supported in the actions.

@DukeFerdinand DukeFerdinand merged commit 1dc3dfd into main Dec 23, 2024
6 of 7 checks passed
@DukeFerdinand DukeFerdinand deleted the migration/package-update/node-v22 branch December 23, 2024 20:06
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
5 participants