-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(menu): add multi-select #133
Draft
chrisfalaska
wants to merge
2
commits into
beta
Choose a base branch
from
cfriedberg/123
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces multi-select functionality to the Sequence diagram for multi-select interaction in AuroMenusequenceDiagram
participant User
participant AuroMenu
participant MenuOption
User->>AuroMenu: Click option
AuroMenu->>AuroMenu: toggleSelectionState(option)
alt option is selected
AuroMenu->>MenuOption: handleDeselectState()
MenuOption-->>AuroMenu: Remove from selected array
else option is not selected
AuroMenu->>MenuOption: handleLocalSelectState()
MenuOption-->>AuroMenu: Add to selected array
end
AuroMenu-->>User: Update UI with selection state
Sequence diagram for loading state handlingsequenceDiagram
participant Component
participant AuroMenu
participant LoadingSlots
Component->>AuroMenu: Set loading=true
AuroMenu->>LoadingSlots: Check for loading placeholders
alt has loading placeholders
LoadingSlots-->>AuroMenu: Return placeholder content
AuroMenu->>Component: Display loading UI with placeholders
else no loading placeholders
AuroMenu->>Component: Hide content while loading
end
Component->>AuroMenu: Set loading=false
AuroMenu->>Component: Restore normal content
Class diagram showing the updated AuroMenu component with multi-select supportclassDiagram
class AuroMenu {
-Boolean disabled
-Boolean loading
-Boolean multiSelect
-Boolean noCheckmark
-Object optionActive
-Map loadingSlots
+handleLocalSelectState(option)
+handleDeselectState(option)
+toggleSelectionState(option)
+selectByValue(value)
+get hasLoadingPlaceholder()
}
note for AuroMenu "Added multi-select and loading support"
class AuroMenuOption {
-Boolean selected
-String value
-Boolean disabled
-Boolean loadingplaceholder
}
AuroMenu *-- AuroMenuOption : contains
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
chrisfalaska seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Multi-select was originally added to
auro-menu
as a pending PR in AlaskaAirlines/auro-menu#199.This feature was never merged or integrated but was selected for adoption into
@auro-formkit/auro-menu
. This PR incorporates that adoption into theformkit
monorepo.Testing
menu-muli-select.mp4
Summary by Sourcery
Add multi-select functionality to the menu component and implement loading states for combobox, menu, and select components. Update documentation and fix multiple bugs.
New Features:
auro-menu
.Tests: