merging new components into main #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request integrates new components (auro-menu and auro-checkbox) and enhances the auro-input component with new date input types. The implementation includes refactoring the component registration method, updating dependencies, and improving test coverage. Class diagram for auro-input enhancementsclassDiagram
class BaseInput {
+String[] dateTypes
+String[] autoFormattingTypes
+void handleClickClear()
+void setCustomValidityForType()
+void render()
}
class AuroInput {
+void register(String name)
+boolean isDateType()
+void render()
}
BaseInput <|-- AuroInput
note for AuroInput "Added new date input types: 'month', 'year', 'fullYear'"
note for BaseInput "Refactored to handle new date input types with validation and formatting"
Class diagram for new components auro-menu and auro-checkboxclassDiagram
class AuroMenu {
+String value
+Object optionSelected
+String matchWord
+boolean disabled
+boolean noCheckmark
+void makeSelection()
+void resetOptionsStates()
+void selectNextItem(String moveDirection)
}
class AuroCheckbox {
+boolean checked
+boolean disabled
+boolean error
+String id
+String name
+String value
+void handleChange(Event event)
+void handleInput(Event event)
}
note for AuroMenu "New component for menu options with selection and event handling"
note for AuroCheckbox "New component for checkbox with state management"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
sun-mota
changed the title
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @sun-mota - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider consolidating duplicate build scripts across components to reduce maintenance overhead and ensure consistency.
- The lowered test coverage thresholds (70% from 80%) should be temporary - please create a follow-up ticket to restore higher coverage requirements once component integration is complete.
Here's what I looked at during the review
- 🟡 General issues: 9 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟡 Complexity: 5 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- `AuroForm.register` is to easily register the element without extra importing
- `import '@aurodesignsystem/auro-form'` will still register this element to `<auro-form>`
- `import { AuroForm } from '../src/auro-form'` wont register this element until `AuroForm.register` gets called
sun-mota
force-pushed
the
sunMota/componentIntegration
branch
from
72f3f21 to
fead88b
Compare
chrisfalaska
approved these changes
Nov 25, 2024
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Merging PRs below at once
formwith new component registration logic & update input to latest version #21A separate PR to come later for below
Summary by Sourcery
Integrate new components auro-menu and auro-checkbox into the project, along with new date input types for auro-input. Update build scripts and dependencies, and enhance documentation and test coverage for these additions.
New Features:
Enhancements:
Build:
Documentation:
Tests:
Summary by Sourcery
Integrate new components auro-menu and auro-checkbox into the project, along with new date input types for auro-input. Update build scripts and dependencies, and enhance documentation and test coverage for these additions.
New Features:
Enhancements:
Build:
Documentation:
Tests: