-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AURO MIGRATION: Update node to v22 #132
Conversation
Reviewer's Guide by SourceryThis pull request updates the project to use Node.js v22 and introduces several improvements to the contribution guidelines and workflows. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
# Only release on push to master | ||
if: github.event_name == 'push' && github.ref == 'refs/heads/master' || 'refs/heads/beta' | ||
# Only release on push to main | ||
if: github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/beta') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The condition for beta branch is incorrectly formatted and will always evaluate to true
The current condition 'refs/heads/beta'
is just evaluating a string literal. It should be github.ref == 'refs/heads/beta'
for proper comparison.
86a9ab0
to
162a49b
Compare
Resolves AlaskaAirlines/auro-templates#6
Summary by Sourcery
Update Node to v22 and revise contributing guidelines.
Build:
CI:
Documentation: