Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #132

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and revise contributing guidelines.

Build:

  • Update Node to v22.

CI:

  • Update CI to test on Node 20 and 22.

Documentation:

  • Revise contributing guidelines, including updating issue templates and adding a new pull request template.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:42
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the project to use Node.js v22 and introduces several improvements to the contribution guidelines and workflows.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated Node.js version to v22 in the test and publish workflow.
  • Updated Node.js version to v22 in package.json.
  • Updated Node.js version to v22 in the CodeQL workflow.
.github/workflows/testPublish.yml
package.json
.github/workflows/codeql.yml
Improved contribution guidelines
  • Added more details and context to the contribution guidelines.
  • Clarified the process for submitting issues and pull requests.
  • Added information about rebasing and conventional commits.
.github/CONTRIBUTING.md
Updated issue templates
  • Added exit criteria to the issue templates.
  • Updated the bug report template to clarify content requirements.
  • Updated the feature request template to include exit criteria.
.github/ISSUE_TEMPLATE/bug_report.yml
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml
Updated workflows
  • Added a new workflow to publish a demo.
  • Updated the stale workflow configuration.
.github/workflows/publishDemo.yml
.github/stale.yml
Updated repository settings
  • Updated the allowed rebase merge setting.
  • Updated team permissions.
  • Updated branch protection rules.
  • Updated status checks.
.github/settings.yml
Updated code of conduct
  • Updated the code of conduct to reflect current standards.
.github/CODE_OF_CONDUCT.md
Updated pull request template
  • Updated the pull request template to include a checklist.
.github/PULL_REQUEST_TEMPLATE.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

github-actions bot commented Dec 20, 2024

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

# Only release on push to master
if: github.event_name == 'push' && github.ref == 'refs/heads/master' || 'refs/heads/beta'
# Only release on push to main
if: github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/beta')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The condition for beta branch is incorrectly formatted and will always evaluate to true

The current condition 'refs/heads/beta' is just evaluating a string literal. It should be github.ref == 'refs/heads/beta' for proper comparison.

@jordanjones243 jordanjones243 force-pushed the migration/package-update/node-v22 branch from 86a9ab0 to 162a49b Compare December 20, 2024 22:10
@jordanjones243 jordanjones243 merged commit cb06869 into main Dec 20, 2024
6 of 7 checks passed
@jordanjones243 jordanjones243 deleted the migration/package-update/node-v22 branch December 20, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
2 participants