Skip to content

Commit

Permalink
fix: ariaPressed name changed to prevent conflict with html attribute #…
Browse files Browse the repository at this point in the history
  • Loading branch information
rmenner committed Dec 2, 2024
1 parent 5759134 commit 2c176a4
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 22 deletions.
6 changes: 1 addition & 5 deletions demo/api.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
href="https://cdn.jsdelivr.net/npm/[email protected]/themes/prism.css"
/>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/design-tokens@latest/dist/tokens/CSSCustomProperties.css">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/design-tokens@latest/dist/tokens/CSSCustomProperties.css">
<link rel="stylesheet" type="text/css" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/webcorestylesheets@latest/dist/demoWrapper.css" />
<link rel="stylesheet" type="text/css" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/webcorestylesheets@latest/dist/elementDemoStyles.css" />
<style>
Expand All @@ -46,12 +45,9 @@
Prism.highlightAll();
});
</script>
<script type="module" src="./api.min.js"></script>
<script defer type="module" src="./api.min.js"></script>

<!-- If additional elements are needed for the demo, add them here. -->
<script src="https://cdn.jsdelivr.net/npm/@aurodesignsystem/auro-accordion@latest/dist/auro-accordion__bundled.js" type="module"></script>
<script>
initHyperlinkApiExamples();
</script>
</body>
</html>
2 changes: 2 additions & 0 deletions demo/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ export function initHyperlinkApiExamples(initCount) {
}
}
}

initHyperlinkIndexExamples();
10 changes: 6 additions & 4 deletions demo/api.min.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,17 +148,17 @@ class ComponentBase extends h {
/**
* @private
*/
this.ariaPressed = 'false';
this.ariapressed = 'false';

/**
* @private
*/
this.tabIsActive = 'false';

/**
/**
* @private
*/
this.runtimeUtils = new AuroLibraryRuntimeUtils$1();
this.runtimeUtils = new AuroLibraryRuntimeUtils$1();

/*
If the component requires a touch detection,
Expand Down Expand Up @@ -1039,7 +1039,7 @@ class AuroHyperlink extends ComponentBase {
${this.safeUri || this.role ? ke`
<a
part="link"
aria-pressed="${to(this.role === 'button' ? this.ariaPressedState(this.ariaPressed) : undefined)}"
aria-pressed="${to(this.role === 'button' ? this.ariaPressedState(this.ariapressed) : undefined)}"
class="${Rt(classes)}"
href="${to(this.role ? undefined : this.safeUri)}"
rel="${to(this.target || this.rel ? this.getRelType(this.target, this.rel) : undefined)}"
Expand All @@ -1062,3 +1062,5 @@ AuroHyperlink.register();
function initHyperlinkApiExamples(initCount) {
}

initHyperlinkIndexExamples();

6 changes: 1 addition & 5 deletions demo/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
href="https://cdn.jsdelivr.net/npm/[email protected]/themes/prism.css"
/>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/design-tokens@latest/dist/tokens/CSSCustomProperties.css">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/design-tokens@latest/dist/tokens/CSSCustomProperties.css">
<link rel="stylesheet" type="text/css" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/webcorestylesheets@latest/dist/demoWrapper.css" />
<link rel="stylesheet" type="text/css" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/webcorestylesheets@latest/dist/elementDemoStyles.css" />
<style>
Expand All @@ -46,12 +45,9 @@
Prism.highlightAll();
});
</script>
<script type="module" src="./index.min.js"></script>
<script defer type="module" src="./index.min.js"></script>

<!-- If additional elements are needed for the demo, add them here. -->
<script src="https://cdn.jsdelivr.net/npm/@aurodesignsystem/auro-accordion@latest/dist/auro-accordion__bundled.js" type="module"></script>
<script>
initHyperlinkIndexExamples();
</script>
</body>
</html>
2 changes: 2 additions & 0 deletions demo/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ export function initHyperlinkIndexExamples(initCount) {
}
}
}

initHyperlinkIndexExamples();
10 changes: 6 additions & 4 deletions demo/index.min.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,17 +176,17 @@ class ComponentBase extends h {
/**
* @private
*/
this.ariaPressed = 'false';
this.ariapressed = 'false';

/**
* @private
*/
this.tabIsActive = 'false';

/**
/**
* @private
*/
this.runtimeUtils = new AuroLibraryRuntimeUtils$1();
this.runtimeUtils = new AuroLibraryRuntimeUtils$1();

/*
If the component requires a touch detection,
Expand Down Expand Up @@ -1067,7 +1067,7 @@ class AuroHyperlink extends ComponentBase {
${this.safeUri || this.role ? ke`
<a
part="link"
aria-pressed="${to(this.role === 'button' ? this.ariaPressedState(this.ariaPressed) : undefined)}"
aria-pressed="${to(this.role === 'button' ? this.ariaPressedState(this.ariapressed) : undefined)}"
class="${Rt(classes)}"
href="${to(this.role ? undefined : this.safeUri)}"
rel="${to(this.target || this.rel ? this.getRelType(this.target, this.rel) : undefined)}"
Expand Down Expand Up @@ -1103,3 +1103,5 @@ function initHyperlinkIndexExamples(initCount) {
}
}

initHyperlinkIndexExamples();

2 changes: 1 addition & 1 deletion src/auro-hyperlink.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export class AuroHyperlink extends ComponentBase {
${this.safeUri || this.role ? html`
<a
part="link"
aria-pressed="${ifDefined(this.role === 'button' ? this.ariaPressedState(this.ariaPressed) : undefined)}"
aria-pressed="${ifDefined(this.role === 'button' ? this.ariaPressedState(this.ariapressed) : undefined)}"
class="${classMap(classes)}"
href="${ifDefined(this.role ? undefined : this.safeUri)}"
rel="${ifDefined(this.target || this.rel ? this.getRelType(this.target, this.rel) : undefined)}"
Expand Down
6 changes: 3 additions & 3 deletions src/component-base.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,17 @@ export default class ComponentBase extends LitElement {
/**
* @private
*/
this.ariaPressed = 'false';
this.ariapressed = 'false';

/**
* @private
*/
this.tabIsActive = 'false';

/**
/**
* @private
*/
this.runtimeUtils = new AuroLibraryRuntimeUtils();
this.runtimeUtils = new AuroLibraryRuntimeUtils();

/*
If the component requires a touch detection,
Expand Down

0 comments on commit 2c176a4

Please sign in to comment.