Skip to content

Commit

Permalink
refactor: update feature per review feedback
Browse files Browse the repository at this point in the history
Changes to be committed:
modified:   demo/demo.md
modified:   docs/api.md
modified:   src/auro-icon.js
  • Loading branch information
blackfalcon authored and jason-capsule42 committed Dec 28, 2022
1 parent 7d3e688 commit 8b153cc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
4 changes: 3 additions & 1 deletion demo/demo.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ In situations where the icon is to be listed with a descriptive label, simply us
<span slot="trigger">See code</span>

```html
<auro-icon label category="in-flight" name="wifi">Your flight is enabled with super fast Wi-Fi</auro-icon>
<auro-icon label category="in-flight" name="wifi">
Your flight is enabled with super fast Wi-Fi
</auro-icon>
```

</auro-accordion>
Expand Down
1 change: 0 additions & 1 deletion docs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ auro-icon provides users a way to use the Auro Icons by simply passing in the ca
| `onDark` | `onDark` | `Boolean` | false | Set value for on-dark version of auro-icon |
| `primary` | `primary` | `Boolean` | | Sets the icon to use the baseline primary icon style. |
| `success` | `success` | `Boolean` | | Sets the icon to use the success style. |
| `title` | `title` | `String` | | Set custom description of icon in use. |
| `warning` | `warning` | `Boolean` | | Sets the icon to use the warning style. |

## Slots
Expand Down
5 changes: 0 additions & 5 deletions src/auro-icon.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import styleCss from "./iconStyle-css.js";
* @attr {Boolean} disabled - Sets the icon to use the disabled style.
* @attr {Boolean} warning - Sets the icon to use the warning style.
* @attr {String} ariaHidden - Set aria-hidden value. Default is `true`. Option is `false`.
* @attr {String} title - Set custom description of icon in use.
* @slot - Hidden from visibility, used for a11y if icon description is needed.
*/

Expand Down Expand Up @@ -114,10 +113,6 @@ class AuroIcon extends BaseIcon {
ariaHidden: {
type: String,
reflect: true
},
title: {
type: String,
reflect: true
}
};
}
Expand Down

0 comments on commit 8b153cc

Please sign in to comment.