-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jbaker/refactor icon sizing #148
Jbaker/refactor icon sizing #148
Conversation
Reviewer's Guide by SourceryThis PR refactors the icon sizing implementation in the auro-icon component, replacing the customSize attribute with a CSS custom property approach. The changes improve the component's flexibility and maintainability by using CSS variables for size control instead of relying on attribute-based styling. Class diagram for auro-icon component changesclassDiagram
class AuroIcon {
- customSize: Boolean
+ --ds-auro-icon-size: CSSVariable
category: String
name: String
customColor: Boolean
}
note for AuroIcon "Replaced customSize attribute with --ds-auro-icon-size CSS variable"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I think I am starting to understand how our theming works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to run build to update API docs
4a35d46
to
0e0c39d
Compare
BREAKING CHANGE: the old customSize attribute is no longer supported. See new documentation on API page under Theme Support.
0e0c39d
to
ea82aef
Compare
89056f1
into
sunMota/feat/easierRegistry/144
Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team