Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update size token to use new icon-size token #153 #154

Merged

Conversation

rmenner
Copy link
Contributor

@rmenner rmenner commented Nov 8, 2024

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Enhancements:

  • Update CSS variable from --ds-size-300 to --ds-auro-icon-size for consistency with new icon size token.

@rmenner rmenner self-assigned this Nov 8, 2024
@rmenner rmenner requested a review from a team as a code owner November 8, 2024 19:56
Copy link

sourcery-ai bot commented Nov 8, 2024

Reviewer's Guide by Sourcery

This PR updates the icon size token from a generic design system token (ds-size-300) to a more specific icon-related token (ds-auro-icon-size) while maintaining the same 100% value. This change aligns with better semantic naming conventions for design tokens.

Class diagram for CSS variable update

classDiagram
    class Host {
        - --ds-size-300: 100%
        + --ds-auro-icon-size: 100%
    }
    note for Host "Updated CSS variable for better semantic naming"
Loading

File-Level Changes

Change Details Files
Updated design token name for icon sizing
  • Replaced --ds-size-300 with --ds-auro-icon-size
  • Maintained the value of 100% for the token
src/alaskaStyle.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@rmenner rmenner linked an issue Nov 8, 2024 that may be closed by this pull request
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rmenner - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please ensure you complete the self-review checkbox in the PR template before submitting
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

demo/alaska.min.js Outdated Show resolved Hide resolved
demo/api.min.js Outdated Show resolved Hide resolved
@jason-capsule42 jason-capsule42 changed the base branch from master to sunMota/new-build-scripting/155 November 12, 2024 17:30
@rmenner rmenner force-pushed the rmenner/alaska-logo/custom-size branch from 1f43cbf to 97718de Compare November 12, 2024 17:44
@rmenner rmenner merged commit 76fafe7 into sunMota/new-build-scripting/155 Nov 12, 2024
1 check passed
@rmenner rmenner deleted the rmenner/alaska-logo/custom-size branch November 12, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-alaska sizing is broken
2 participants