fix: update markdown partial pathing to consume new auro lib #155 #156
+619
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR updates the file path references in markdown files and configuration to align with the new auro library structure. It also upgrades the auro-library dependency to version 3.0.1. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| var official200 = {"hidden":"true","category":"restricted","role":"img","color":"currentColor","desc":"Logo image for Alaska Airlines","width":"100%","height":"auto","xmlns":"http://www.w3.org/2000/svg","xmlns_xlink":"http://www.w3.org/1999/xlink","path":"/icons/restricted","style":"","type":"restricted","name":"AS-tagline-200","title":"Alaska Airlines","viewBox":"0 0 83 35","svg":"<svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" aria-labelledby=\"AS-tagline-200__title AS-tagline-200__desc\" role=\"img\" style=\"min-width:100%;height:auto;fill:currentColor\" viewBox=\"0 0 83 35\" part=\"svg\"><title id=\"AS-tagline-200__title\">Alaska Airlines</title><desc id=\"AS-tagline-200__desc\">Logo image for Alaska Airlines</desc><path d=\"M10.2 33.4H7.6l-.5 1.5H5.8l2.4-6.4h1.4l2.4 6.4h-1.3zM8 32.2h1.8l-.9-2.4zM16.5 34.8v-6.4h1.3v6.4zM25 32.4h-.6v2.5h-1.2v-6.4h2.5c1.2 0 2 .9 2 2 0 .9-.5 1.6-1.4 1.8l1.4 2.6h-1.4zm.3-1.1c.6 0 1-.4 1-.9s-.4-.9-1-.9h-1v1.8zM32.6 34.8v-6.4h1.2v5.2h2.8v1.2zM41.6 34.8v-6.4h1.3v6.4zM52.3 34.8l-2.9-4.5v4.5h-1.2v-6.4h1.5l2.6 4.2v-4.2h1.2v6.4zM59 34.8v-6.4h4v1.2h-2.7v1.5h2.5v1.1h-2.5v1.5H63v1.2h-4zM71.3 30.3c-.1-.4-.4-.9-1.2-.9-.6 0-1 .4-1 .8s.2.6.7.7l.9.2c1.2.2 1.8 1 1.8 1.9 0 1-.8 2-2.3 2-1.7 0-2.4-1.1-2.5-2l1.1-.3c.1.6.5 1.2 1.4 1.2.7 0 1-.3 1-.8 0-.4-.3-.7-.8-.8l-.9-.2c-1-.2-1.7-.9-1.7-1.8 0-1.1 1-2 2.2-2 1.5 0 2.1.9 2.3 1.7zM39.7 1l-9.2 15.5c-1 1.6-1.5 3.2-1.6 4.8h-3.6c.2-2 1-3.8 2.6-6.5L34.4 4c1.2-2.3 2.5-3 4.8-3zM39 17.3c-.7.6-2 1.6-3.1 1.6-.8 0-.8-.7-.3-1.7 2-3.7 4-5.7 6.5-5.7h.5zm3.4-8c-4.7 0-7.6 2.7-10.1 8.7-.6 1.5-1 3.4 1.2 3.3 1.2 0 3.3-.7 4.8-1.7-.1.5-.2 1.2-.1 1.6h3.3c.1-1.3.6-2.9 1.7-4.8l4.1-6.9c-1.7-.1-3.3-.2-4.9-.2M72.8 17.3c-.7.6-2 1.6-3.1 1.6-.8 0-.8-.7-.3-1.7 2-3.7 4-5.7 6.5-5.7h.5zm3.4-8c-4.7 0-7.6 2.7-10.1 8.7-.6 1.5-1 3.4 1.2 3.3 1.2 0 3.3-.7 4.8-1.7-.1.5-.2 1.2-.1 1.6h3.3c.1-1.3.6-2.9 1.7-4.8l4-6.8q-2.4-.3-4.8-.3\"/><path d=\"M65.5 24.6h-1.1c-1.4 0-2.6-.9-3-2.3l-1.6-6.2-3.1 5.1h-3.5L63 4.6c1.3-2.1 2.6-2.9 4.9-2.9h.4l-6.5 11 4.9-3.4h3.9L62.4 15zM33.3 0c-3.3 0-5 .9-8.2 3.2l-11 7.9H7c-2 0-3.7.1-4.9 1.3L.3 14.1s5.3-.2 10.2-.4L0 21.2h4.5l10.7-7.7c2.1-.1 3.5-.1 3.5-.1 2.5-.1 3.9-2.3 3.9-2.3h-4.1l8.7-6.3-6.4 10.4c-1.4 2.4-2 4.1-2.3 5.9h3.7c.1-1.6.7-3.2 1.6-4.8l8.8-14.7c.6-1 1.1-1.8 1.1-1.8zM50.7 12.7c0 .3.1.5.7.9l1 .7c1.1.7 1.5 1.8 1.4 2.7-.4 2.5-2.2 4.4-6 4.4-1.7 0-2.4-.1-4.4-.4l1.5-2.5c1.4.2 2.2.4 3.2.4 1.4 0 2-.7 2.1-1.2 0-.3-.1-.7-.8-1.2l-.8-.6c-1.3-.9-1.6-1.6-1.4-2.8.3-2.2 2.8-3.8 6.3-3.8 1.1 0 2.3.1 3.6.2l-1.4 2.4c-.9-.1-2.3-.1-3.2-.1-1 0-1.7.4-1.8.9M80.7 17.7c1 0 1.8.8 1.8 1.9 0 1-.8 1.9-1.8 1.9s-1.8-.8-1.8-1.9c0-1 .8-1.9 1.8-1.9m0 3.4c.8 0 1.4-.6 1.4-1.5 0-.8-.6-1.5-1.4-1.5s-1.4.6-1.4 1.5c0 .8.6 1.5 1.4 1.5m-.2-.5h-.4v-2h.7c.4 0 .7.3.7.6s-.2.5-.4.6l.5.8H81l-.4-.8h-.2v.8zm.2-1.1c.2 0 .4-.1.4-.3s-.1-.3-.4-.3h-.3v.6z\"/></svg>"}; | ||
|
|
||
| var official100 = {"hidden":"true","category":"restricted","role":"img","color":"currentColor","desc":"Logo image for Alaska Airlines","width":"100%","height":"auto","xmlns":"http://www.w3.org/2000/svg","xmlns_xlink":"http://www.w3.org/1999/xlink","path":"/icons/restricted","style":"","type":"restricted","name":"AS-tagline-100","title":"Alaska Airlines","viewBox":"0 0 57 24","svg":"<svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" aria-labelledby=\"AS-tagline-100__title AS-tagline-100__desc\" role=\"img\" style=\"min-width:100%;height:auto;fill:currentColor\" viewBox=\"0 0 57 24\" part=\"svg\"><title id=\"AS-tagline-100__title\">Alaska Airlines</title><desc id=\"AS-tagline-100__desc\">Logo image for Alaska Airlines</desc><path d=\"M6.8 22.2H5.1l-.4 1h-.9L5.5 19h1L8 23.2h-.8zm-1.4-.7h1.2L6 19.9zM11 23.2V19h.8v4.2zM16.7 21.6h-.4v1.6h-.8V19h1.7c.8 0 1.4.6 1.4 1.3q0 .9-.9 1.2l.9 1.7h-.9zm.2-.7c.4 0 .7-.2.7-.6s-.2-.6-.7-.6h-.7v1.2zM21.7 23.2V19h.8v3.5h1.9v.8h-2.7zM27.7 23.2V19h.8v4.2zM34.9 23.2l-1.9-3v3h-.8V19h1l1.8 2.8V19h.8v4.2zM39.3 23.2V19H42v.8h-1.8v1h1.7v.7h-1.7v1H42v.8h-2.7zM47.5 20.2c0-.2-.2-.6-.8-.6-.4 0-.7.3-.7.5s.1.4.5.5l.6.1c.8.2 1.2.7 1.2 1.2 0 .7-.5 1.3-1.5 1.3-1.1 0-1.6-.7-1.7-1.3l.8-.2c0 .4.3.8.9.8.4 0 .7-.2.7-.5 0-.2-.2-.4-.5-.5l-.6-.1c-.7-.1-1.1-.6-1.1-1.2 0-.8.7-1.3 1.5-1.3 1 0 1.4.6 1.5 1.1zM26.5.6 20.3 11c-.6 1.1-1 2.1-1.1 3.2h-2.4c.2-1.3.7-2.6 1.7-4.3l4.3-7.2c.9-1.4 1.7-2 3.3-2h.4zM26 11.5c-.5.4-1.3 1-2.1 1.1-.5 0-.5-.5-.2-1.2 1.3-2.5 2.7-3.8 4.4-3.8h.3zm2.3-5.3c-3.1 0-5 1.8-6.7 5.8-.4 1-.7 2.2.8 2.2.8 0 2.2-.5 3.2-1.1-.1.3-.1.8-.1 1.1h2.2c.1-.9.4-1.9 1.1-3.2l2.7-4.6c-1.1-.1-2.1-.2-3.2-.2M48.5 11.5c-.5.4-1.3 1-2.1 1.1-.5 0-.5-.5-.2-1.2 1.3-2.5 2.7-3.8 4.4-3.8h.4zm2.3-5.3c-3.1 0-5 1.8-6.7 5.8-.4 1-.7 2.2.8 2.2.8 0 2.2-.5 3.2-1.1-.1.3-.1.8-.1 1.1h2.2c.1-.9.4-1.9 1.1-3.2L54 6.4c-1-.1-2.1-.2-3.2-.2\"/><path d=\"M43.7 16.4H43c-.9 0-1.7-.6-2-1.5l-1.1-4.1-2 3.4h-2.3l6.5-11c.8-1.4 1.7-2 3.3-2h.2l-4.3 7.3 3.2-2.2h2.6L41.6 10zM22.2 0c-2.2 0-3.3.6-5.5 2.1L9.4 7.4H4.7c-1.4 0-2.4.1-3.3.9L.2 9.4s3.5-.1 6.8-.3l-7 5h3L10.2 9c1.4-.1 2.4-.1 2.4-.1 1.7 0 2.6-1.5 2.6-1.5h-2.7l5.8-4.2-4.3 7c-.9 1.6-1.4 2.7-1.5 4H15c.1-1 .4-2.1 1.1-3.2L22 1.2c.2-.7.5-1.2.5-1.2zM33.8 8.4c0 .2.1.3.5.6l.7.5c.7.5 1 1.2.9 1.8-.2 1.6-1.4 3-4 3-1.1 0-1.6 0-3-.3l1-1.7c.9.2 1.5.2 2.1.2 1 0 1.3-.4 1.4-.8 0-.2-.1-.5-.5-.8l-.5-.4c-.9-.6-1.1-1.1-1-1.8.2-1.4 1.9-2.6 4.2-2.6.7 0 1.5 0 2.4.1l-.9 1.6c-.6 0-1.5-.1-2.2-.1-.6.2-1 .4-1.1.7M55.2 10.9c.9 0 1.7.8 1.7 1.7s-.8 1.7-1.7 1.7-1.7-.8-1.7-1.7.8-1.7 1.7-1.7m0 3.1c.7 0 1.3-.6 1.3-1.4s-.6-1.4-1.3-1.4-1.3.6-1.3 1.4.6 1.4 1.3 1.4m-.2-.5h-.3v-1.8h.6c.4 0 .6.3.6.6s-.2.5-.4.5l.4.7h-.4l-.4-.7H55zm.2-1q.3 0 .3-.3t-.3-.3H55v.5h.2z\"/></svg>"}; |
There was a problem hiding this comment.
issue (code-quality): Use const or let instead of var. (avoid-using-var)
Explanation
`const` is preferred as it ensures you cannot reassign references (which can lead to buggy and confusing code). `let` may be used if you need to reassign references - it's preferred to `var` because it is block- rather than function-scoped.From the Airbnb JavaScript Style Guide
chrisfalaska
approved these changes
Nov 12, 2024
|
🎉 This PR is included in version 6.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #155
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Update markdown partial paths to reflect the new auro library structure and upgrade the '@aurodesignsystem/auro-library' dependency to version '^3.0.1'.
Bug Fixes:
Enhancements: