Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct naming in function for exporting css parts #159

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 3, 2024

Alaska Airlines Pull Request

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Fix the naming in the 'exposeCssParts' function to ensure correct CSS part exports and update the README.md with the latest auro-icon module version.

Bug Fixes:

  • Correct the naming in the 'exposeCssParts' function to properly export CSS parts for styling.

Documentation:

  • Update the README.md to reflect the new version of the auro-icon module.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 3, 2024 06:46
Copy link

sourcery-ai bot commented Dec 3, 2024

Reviewer's Guide by Sourcery

This PR fixes an issue with CSS part naming in the auro-icon component by correcting the exportparts attribute value. It also includes an update to the bundled script version in the documentation.

Class diagram for AuroIcon component changes

classDiagram
    class AuroIcon {
        +exposeCssParts() void
    }
    note for AuroIcon "Updated exportparts attribute from 'iconSvg:svg' to 'svg:iconSvg'"
Loading

File-Level Changes

Change Details Files
Fixed CSS parts export naming in the component
  • Swapped the order of parts in exportparts attribute from 'iconSvg:svg' to 'svg:iconSvg' to correctly map the exposed part name
  • This change ensures proper CSS part exposure for parent component styling
src/auro-icon.js
Updated component version reference in documentation
  • Bumped auro-icon version from 6.0.3 to 6.1.0 in the CDN script URL
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@jason-capsule42 jason-capsule42 self-assigned this Dec 3, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jason-capsule42 jason-capsule42 merged commit c81ee28 into master Dec 3, 2024
6 checks passed
@jason-capsule42 jason-capsule42 deleted the jbaker/fixPartsExport branch December 3, 2024 06:48
@blackfalcon
Copy link
Member

🎉 This PR is included in version 6.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants