-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AURO MIGRATION: Update node to v22 #46
Conversation
Reviewer's Guide by SourceryThis pull request updates the Auro Lockup project to use Node.js v22 and implements Conventional Commits. It also updates the contributing guidelines, issue templates, and GitHub settings. State diagram: PR workflow with Conventional CommitsstateDiagram-v2
[*] --> IssueCreated: Create Issue
IssueCreated --> TeamConsultation: Consult Auro Team
TeamConsultation --> Development: Begin Development
Development --> CommitChanges: Make Changes
CommitChanges --> ConventionalCommit: Format Commit Message
state ConventionalCommit {
[*] --> Type
Type --> Scope: Add optional scope
Scope --> Description: Add description
Description --> Body: Add optional body
Body --> Footer: Add optional footer
Footer --> [*]
}
ConventionalCommit --> PullRequest: Submit PR
PullRequest --> [*]: Merge
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR removes several contact/discussion links from .github/ISSUE_TEMPLATE/config.yml without replacement. Consider preserving these support channels or documenting alternative ways for users to engage with the project.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to merge #45
cf42e2d
to
fd59351
Compare
🎉 This PR is included in version 4.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves AlaskaAirlines/auro-templates#6
Summary by Sourcery
Update Node to v22 and configure CI to test against Node 20 and 22.
Enhancements:
CI:
Tests: