Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #46

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and configure CI to test against Node 20 and 22.

Enhancements:

  • Update Node to v22.

CI:

  • Test against Node 20 and 22.

Tests:

  • Update test matrix to include Node 22.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:45
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the Auro Lockup project to use Node.js v22 and implements Conventional Commits. It also updates the contributing guidelines, issue templates, and GitHub settings.

State diagram: PR workflow with Conventional Commits

stateDiagram-v2
    [*] --> IssueCreated: Create Issue
    IssueCreated --> TeamConsultation: Consult Auro Team
    TeamConsultation --> Development: Begin Development
    Development --> CommitChanges: Make Changes
    CommitChanges --> ConventionalCommit: Format Commit Message

    state ConventionalCommit {
        [*] --> Type
        Type --> Scope: Add optional scope
        Scope --> Description: Add description
        Description --> Body: Add optional body
        Body --> Footer: Add optional footer
        Footer --> [*]
    }

    ConventionalCommit --> PullRequest: Submit PR
    PullRequest --> [*]: Merge
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated Node.js version to v22 in the test and publish workflow.
  • Updated the engines section in package.json to specify Node.js v22.
  • Regenerated package-lock.json to reflect the Node.js version update.
.github/workflows/testPublish.yml
package.json
package-lock.json
Implemented Conventional Commits
  • Added information about Conventional Commits and commit message formatting to the contributing guidelines.
.github/CONTRIBUTING.md
Updated contributing guidelines
  • Clarified the process for submitting issues and pull requests.
  • Updated guidance on rebasing and forking.
  • Added information about write access requests.
.github/CONTRIBUTING.md
Updated issue templates
  • Disabled blank issue creation.
  • Added new YAML-based issue templates for feature requests and general support.
  • Removed old Markdown-based issue templates.
.github/ISSUE_TEMPLATE/config.yml
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
Updated GitHub settings
  • Updated repository topics.
  • Added team access settings.
  • Updated branch protection rules to include Node.js v22 tests.
.github/settings.yml
Updated pull request template
  • Simplified the pull request template.
.github/PULL_REQUEST_TEMPLATE.md
Updated stale workflow
  • Added configuration for stale issues and pull requests.
.github/stale.yml
Updated CodeQL workflow
  • Removed unused queries from the CodeQL workflow.
.github/workflows/codeql.yml
Updated CODEOWNERS file
  • Updated code ownership rules.
.github/CODEOWNERS
Added publish demo workflow
  • Added a workflow to publish a demo on pull requests to the main branch.
.github/workflows/publishDemo.yml
Updated Code of Conduct
  • Minor updates to the Code of Conduct file.
.github/CODE_OF_CONDUCT.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

github-actions bot commented Dec 20, 2024

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR removes several contact/discussion links from .github/ISSUE_TEMPLATE/config.yml without replacement. Consider preserving these support channels or documenting alternative ways for users to engage with the project.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@rmenner rmenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge #45

sun-mota
sun-mota previously approved these changes Dec 20, 2024
@jason-capsule42 jason-capsule42 force-pushed the migration/package-update/node-v22 branch from cf42e2d to fd59351 Compare December 22, 2024 19:01
@jason-capsule42 jason-capsule42 merged commit 8fd1180 into main Dec 22, 2024
6 of 7 checks passed
@jason-capsule42 jason-capsule42 deleted the migration/package-update/node-v22 branch December 22, 2024 19:05
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
4 participants