-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AURO MIGRATION: Update node to v22 #234
Conversation
Reviewer's Guide by SourceryThis PR updates the project to use Node.js v22 and introduces several improvements to the contributing guidelines and repository settings. State diagram: Updated issue lifecyclestateDiagram-v2
[*] --> Open: Issue created
Open --> InProgress: Work started
Open --> Stale: 30 days inactive
Stale --> Closed: 7 days inactive
InProgress --> Review: PR submitted
Review --> Merged: PR approved
Review --> InProgress: Changes requested
Merged --> [*]
note right of Open
New requirement:
Must consult team
before starting work
end note
note right of Stale
Updated stale bot
configuration
end note
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
.github/workflows/testPublish.yml
Outdated
@@ -29,7 +30,7 @@ jobs: | |||
|
|||
release: | |||
# Only release on push to main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The condition had a logical error that could cause unintended releases
The original condition would always evaluate the second part as true. The fix using parentheses is correct: github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/beta')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need #233
c58aec3
to
fe803d8
Compare
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves AlaskaAirlines/auro-templates#6
Summary by Sourcery
Update Node.js to version 22.
Build:
CI:
Documentation:
Tests: