Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #234

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node.js to version 22.

Build:

  • Update Node engine to support versions 20 and 22.

CI:

  • Update CI workflow to test on Node versions 20 and 22.

Documentation:

  • Update contributing guidelines with information about rebasing, conventional commits, and issue/PR templates.

Tests:

  • Update test matrix to include Node version 22.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:46
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This PR updates the project to use Node.js v22 and introduces several improvements to the contributing guidelines and repository settings.

State diagram: Updated issue lifecycle

stateDiagram-v2
    [*] --> Open: Issue created
    Open --> InProgress: Work started
    Open --> Stale: 30 days inactive
    Stale --> Closed: 7 days inactive
    InProgress --> Review: PR submitted
    Review --> Merged: PR approved
    Review --> InProgress: Changes requested
    Merged --> [*]

    note right of Open
        New requirement:
        Must consult team
        before starting work
    end note

    note right of Stale
        Updated stale bot
        configuration
    end note
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated Node.js version to v22 in the test and publish workflow.
  • Updated Node.js version to v22 in package.json.
  • Regenerated package-lock.json.
  • Updated the test matrix in settings.yml to use Node.js v20 and v22.
  • Removed specific query from codeql.yml workflow.
.github/workflows/testPublish.yml
package.json
package-lock.json
.github/settings.yml
.github/workflows/codeql.yml
Improved contributing guidelines
  • Added guidance for Alaska Airlines employees, contractors, and vendors.
  • Clarified feature request process.
  • Updated issue submission guidelines.
  • Added a 48-hour response time SLA for issue submissions.
  • Added guidance on pull request submissions.
  • Clarified feature branch naming conventions.
  • Added a section on rebasing and avoiding git pull on feature branches.
  • Added information on Conventional Commits and commit message formatting.
  • Included examples of commit messages.
.github/CONTRIBUTING.md
Updated repository settings
  • Removed the repository description.
  • Updated repository topics.
  • Added team access settings.
  • Updated stale bot configuration.
  • Simplified pull request template.
  • Updated code of conduct.
.github/settings.yml
.github/CODEOWNERS
.github/stale.yml
.github/PULL_REQUEST_TEMPLATE.md
.github/CODE_OF_CONDUCT.md
Added issue templates
  • Created a new bug report template.
  • Updated the feature request template.
  • Created a general support template.
.github/ISSUE_TEMPLATE/bug_report.yml
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml
Added demo publishing workflow
  • Created a workflow to publish demos on pull requests to the main branch.
.github/workflows/publishDemo.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

github-actions bot commented Dec 20, 2024

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -29,7 +30,7 @@ jobs:

release:
# Only release on push to main
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The condition had a logical error that could cause unintended releases

The original condition would always evaluate the second part as true. The fix using parentheses is correct: github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/beta')

Copy link
Contributor

@sun-mota sun-mota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need #233

@DukeFerdinand DukeFerdinand force-pushed the migration/package-update/node-v22 branch from c58aec3 to fe803d8 Compare December 23, 2024 19:37
.github/workflows/testPublish.yml Outdated Show resolved Hide resolved
@DukeFerdinand DukeFerdinand merged commit dc93408 into main Dec 23, 2024
6 of 7 checks passed
@DukeFerdinand DukeFerdinand deleted the migration/package-update/node-v22 branch December 23, 2024 20:47
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
5 participants